Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve support for new requireHooks update #2313

Merged
merged 22 commits into from
Oct 12, 2023
Merged

Conversation

taty2010
Copy link
Contributor

@taty2010 taty2010 commented Oct 5, 2023

Description

With the release of Next 13.5+ there were some major updates done within require-hooks along with the removal of appDir from the experimental config.

This fix should:

  • Only run our requireHooks when Next version is 13.3.x-13.4.9 and based on if experimental.appDir exists.
  • Resolve the styled-jsx/style issue

Documentation

Tests

You can test this change yourself like so:

  1. TODO

Relevant links (GitHub issues, etc.) or a picture of cute animal

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 5b51fd2
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6527becf96838500080b29ab
😎 Deploy Preview https://deploy-preview-2313--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 5b51fd2
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/6527becfe9c3cf000811e673
😎 Deploy Preview https://deploy-preview-2313--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 5b51fd2
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6527becfdc270700081bc659
😎 Deploy Preview https://deploy-preview-2313--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 5b51fd2
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6527becf5778690008a74a24
😎 Deploy Preview https://deploy-preview-2313--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 5b51fd2
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/6527becf96838500080b29b0
😎 Deploy Preview https://deploy-preview-2313--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 5, 2023
@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 5b51fd2
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/6527becf6385e80008e014da
😎 Deploy Preview https://deploy-preview-2313--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 5b51fd2
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6527becf16a27c0008f27a92
😎 Deploy Preview https://deploy-preview-2313--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for netlify-plugin-nextjs-demo-all-flags ready!

Name Link
🔨 Latest commit 5b51fd2
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo-all-flags/deploys/6527becf8743020008f31f51
😎 Deploy Preview https://deploy-preview-2313--netlify-plugin-nextjs-demo-all-flags.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 5b51fd2
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/6527becf7cc11d00087671ef
😎 Deploy Preview https://deploy-preview-2313--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 5b51fd2
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/6527becf193bd4000814cd8f
😎 Deploy Preview https://deploy-preview-2313--next-plugin-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taty2010 taty2010 marked this pull request as ready for review October 6, 2023 16:18
@taty2010 taty2010 requested a review from a team as a code owner October 6, 2023 16:18
Copy link
Contributor

@orinokai orinokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a chunky fix, nice one @taty2010 - looks good to me

@kodiakhq kodiakhq bot merged commit e354b73 into main Oct 12, 2023
76 checks passed
@kodiakhq kodiakhq bot deleted the tn/partial-13.5-support branch October 12, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants