-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add blob storage #2287
Merged
Merged
feat: add blob storage #2287
Changes from 213 commits
Commits
Show all changes
221 commits
Select commit
Hold shift + click to select a range
68908b0
feat: adding inital blob setup
taty2010 3fe87c5
feat: added get and set for ssr files
taty2010 2fe2c83
chore: prettier
taty2010 407da47
chore: prettier
taty2010 01f44e3
updated tsconfig and added dynamic imports
taty2010 a75b428
chore: reverted some changes to bring project back to commonjs
nickytonline 79acf0b
chore: some cleanup
nickytonline 7db5872
chore: ran formatter
nickytonline 8b34135
chore: more cleanup related to going back to commonjs
nickytonline a6941f2
chore: reverting some more stuff from async
nickytonline 90333d4
chore: getting blob storage in a usable state in commonjs land
nickytonline bba2391
chore: testing blob storage
nickytonline a9faf28
chore: memoized getting blob storage
nickytonline a20f8c4
chore: small refactor
nickytonline 8c769af
chore: trigger build
nickytonline 271624d
chore: cleaned up blob storage instantiation
nickytonline 7361ef8
chore: fixed types for getting blob storage
nickytonline 4497b56
chore: removed todo comment
nickytonline ae7f9b6
chore: removed a TODO comment
nickytonline 58a62b3
chore: refactored getBlobStorage
nickytonline 4d45ddf
chore: putting up test for Eduardo
nickytonline 110816e
chore: add debug logging
eduardoboucas 171b5a7
refactor: rebuild
eduardoboucas 9f47f42
refactor: remove debug logging
eduardoboucas 1aa8ab1
chore: wip
nickytonline 6e1b151
chore: updated package lock
nickytonline e3b5a74
chore: testing out blob storage for prerendered content
nickytonline a30ffba
chore: added a check for deploy ID for blob storage
nickytonline 4a509fe
chore: small refactor
nickytonline 048a0c2
chore: reverted some refactor not related to the PR
nickytonline d856aec
chore: undid encoding of blob storage keys
nickytonline 0725388
chore: removed unnecessary comment
nickytonline 3604f11
chore: added some logging for blob storage
nickytonline 893b5ee
chore: testing/logging blob storage
nickytonline 26346da
chore: stripping starting slash for blob storage keys
nickytonline 6feaac3
chore: using netliblob.setJSON now instead of .set
nickytonline 913ba1b
chore: cleaned up setting blob storage
nickytonline b464472
chore: fixed issue with ssrDependencies not being iterable
nickytonline 6d4f1be
chore: some logging cleanup
nickytonline 9e44536
chore: reverted some unnecessary changes from 01f44e391c0368e4488ef02…
nickytonline c2dc32d
chore: reverted some unnecessary changes from 01f44e391c0368e4488ef02…
nickytonline e6eb363
chore: reverted some unnecessary changes
nickytonline 1639999
chore: reverted change not related to work in PR
nickytonline ed3cb71
chore: updated package lock
nickytonline 183b7aa
chore: added a comment about starting slashes removed from blob stora…
nickytonline 391feaf
chore: added some more comments
nickytonline e664884
chore: trigger build
nickytonline cc866a1
chore: removed logging feature flags
nickytonline dfc5f21
chore: testing blob storage flag
nickytonline 946dac8
chore: cleaned up blob storage check
nickytonline bce39ce
chore: trigger build
nickytonline 217bd9a
chore: added some temp logging
nickytonline 5af0a8a
Revert "chore: added some temp logging"
nickytonline dc26736
chore: fixed blob storage check condition 🙃
nickytonline eb469b9
chore: bumped @netlify/build to 29.20.15
nickytonline f316e5f
chore: trigger build
nickytonline 0a97c3b
feat: implemented incremental cache
nickytonline 18fc31b
chore: some cleanup
nickytonline aae443c
chore: removed a TODO comment
nickytonline f0e5f6d
chore: wip
nickytonline a9eac3b
chore: refactored getBlobStorage
nickytonline d1d6d00
chore: added incremental cache with memory cache for testing key and …
nickytonline 609945e
add new incremental cache file + store blob
taty2010 7edf24c
removing blob type for now
taty2010 55a5699
updated file location for incremental-cache.js
taty2010 3ef276b
updated filepath
taty2010 cd15334
adding publish dir intead
taty2010 4dd2961
use publish dir for config
taty2010 6fd1266
feat: moving incremental cache to functions
taty2010 9a2f9b3
chore: creating cache file right before config set
taty2010 f1cb1e3
chore: added require.resolve for incremental cache
taty2010 98a2bc2
chore: uncomment import that got commented out during merge
nickytonline 4a5cfb5
chore: no longer infer the type for Blobs
nickytonline a5f66b7
chore: updated @netlify/build to 29.21.0
nickytonline ce8c746
Merge remote-tracking branch 'origin' into nickytonline/blob-storage
nickytonline eb69bcc
chore: formatting fixes
nickytonline 5eb29b7
chore: cleaned up how netliblob is determined for SSR lambdas
nickytonline cc41ab3
chore: now incremental cache handler gets generated if blob storage i…
nickytonline 4059344
chore: fixed resolving file path for blobStorage.js
nickytonline da0edf3
chore: trigger build
nickytonline 296f50c
chore: cleaned up getting blob credentials from context
nickytonline 9863fa8
chore: added some temporary logging
nickytonline fbf1952
chore: added another log statement in incremental cache handler
nickytonline 75d17c3
chore: trigger build
nickytonline f0c92dc
chore: stripped starting slash for keys for now
nickytonline 4b75d4e
chore: changed where incremental cache handler gets put
nickytonline 6e88f67
chore: removed test incremental cache handler from demo site
nickytonline d54e062
Merge remote-tracking branch 'origin' into nickytonline/blob-storage
nickytonline 30075f7
chore: update
lukasholzer f7f511f
chore: update
lukasholzer f7147d7
chore: updates
lukasholzer eb8674f
chore: make blob storage available during runtime
lukasholzer 78a1a08
chore: update
lukasholzer a7f6696
chore: use the blob store during request time differently
lukasholzer 913a6d2
chore: update
lukasholzer b1a4dad
chore: test
lukasholzer 8dfab95
chore: update logging
lukasholzer 2cc9633
chore: update
lukasholzer 43860c6
chore: update
lukasholzer 500e462
chore: update
lukasholzer 6e56190
chore: fix
lukasholzer 54fa413
chore: update
lukasholzer 1538fec
chore: improve logging
lukasholzer 3be1496
chore: update
lukasholzer da170da
chore: update
lukasholzer 3a0a011
chore: update
lukasholzer b9ff1a6
chore: update
lukasholzer b7946c1
chore: change encoding of key
lukasholzer ef2ec91
refactor: remove incremental cache handler injection
pieh 7c91a71
refactor: eslint ignore file via .eslintignore and not config
pieh 1b40b4b
feat: bump @netlify/blobs to 2.0.0 (key hashing)
pieh 2d13071
refactor: allow @netlify/blobs to do the key hashing
pieh 18adedc
refactor: some debugging
pieh bad1b2b
test: will this be set?
pieh 4849ec8
test: will this be set?2
pieh 2375994
test: will this be set?3
pieh 65875bd
test: will this be set?4
pieh 2664912
test: will this be set?5
pieh a118b9e
test: will this be set?6
pieh 299418c
test: will this be set?7
pieh 0e4a3b7
test: will this be set?8
pieh 41cade6
test: will this be set?9
pieh fa32780
fix: lambda response is base64 encoded
pieh 7b270ad
test: check how things look in moveStaticPages
pieh de16614
test: check how things look in moveStaticPages2
pieh 200738f
test: check how things look in moveStaticPages3
pieh 20aff69
test: check if we can skip key normalization already
pieh fb5fd25
fix: don't compile blob helpers for function bundling, copy files ins…
pieh 663b343
feat: cleanup
pieh b5f9a51
fix: clean up lambda a bit
pieh f1201dd
fix: clean up some logs when used locally
pieh dffcc01
fix: move esbuild back to deps, as it's used for middleware compilation
pieh 659f693
feat: don't warm up blobs when configuring functions (we will do this…
pieh 08008f2
fix: more cleanup
pieh 4ccfd0e
feat: start uploading to blob store during static pages moves
pieh ae664e8
feat: log number of assets moved to blob storage and delete those files
pieh 0506a30
test: check simple blob keys ... again
pieh b6ee3a4
test: restore key normalization ... again
pieh 5ab0b49
feat: apply trailing slash to blob keys
pieh a17498a
feat: initial default locale handling
pieh ebb3abd
chore: some logs
pieh 4226d39
fix: commit exported isLocalized
pieh 49519fc
fix: fix isLocalized import
pieh bc5afd3
chore: expose router push
pieh e0449b5
feat: blob manifest for i18n aliases
pieh 6cb125c
chore: log blob manifest
pieh d54f824
fix: fix blobs-manifest filenames
pieh 297320e
chore: a bit more type safety
pieh 468ecc3
chore: bump cypress to latest v12
pieh d6b8646
test: test fix1
pieh dcc1e77
chore: drop some test code
pieh dec7888
fix: remove blobs-manifest before publishing to cdn
pieh e62e879
Merge remote-tracking branch 'origin/main' into nickytonline/blob-sto…
pieh 248dea6
feat: initial headers setting
pieh 5f46053
feat: initial headers setting2
pieh 9b150af
chore: some more visible rsc-data logs
pieh e41a370
chore: some more visible rsc-data logs2
pieh aa3c09d
chore: some more visible rsc-data logs3
pieh edefc1b
fix: normalize path after blob store checks
pieh 310a547
fix: strip trailing slash for .rsc/ paths before checking blob store
pieh 293ed48
test: log maybe more details
pieh 393a92e
test: maybe i will get more details without --json?
pieh 1d24c2b
test: inject global fetch polyfill
pieh 3275332
test: inject global fetch polyfill2
pieh 1d840ae
test: restore json output
pieh 24956d1
test: remove logs from fetch polyfill that were breaking ntl deploy o…
pieh 9c71569
chore: some cleanup
pieh c815d64
chore: cleanup lambda handler
pieh f3a5e0d
chore: drop mime-types dep as it's not used
pieh 69071d5
Merge remote-tracking branch 'origin/main' into nickytonline/blob-sto…
pieh b5ff0ab
test: let's see basepath
pieh c5687c6
chore: revert basepath for now
pieh 189bc12
chore: try out slightly different approach
pieh ef67939
chore: show time on index page
pieh ed18202
chore: fix var name
pieh 25a45bd
chore: set to array fix
pieh bb643a2
test: try pulling from blob store in fs augment
pieh 5320e7f
test: maybe fix blob type
pieh b4d343e
chore: stuff
pieh 3662003
chore: stuff2
pieh e050866
chore: add deployID to logs
pieh ad426cb
chore: log missed blobs
pieh 1fe2413
chore: log filepath
pieh 4ee7225
chore: is cached file being read?
pieh 6a25768
chore: is blobbing erroring out?
pieh 219215b
chore: ensure directory stuff
pieh 1ae3e29
chore: oneline log for easier grepping
pieh 811daf7
chore: more oneliners
pieh dcd1c76
chore: don't use asynclocalstorage ...!
pieh 45a5548
chore: log served message
pieh a40be22
chore: log served message2
pieh 7c67874
chore: what if we use asynclocalstorage later
pieh 4868f7e
chore: cleanups
pieh ed2843f
chore: cleanups2
pieh 542642b
chore: cleanups3
pieh 108dca6
chore: cleanups4
pieh bc75e8f
chore: cleanups5
pieh 686050a
chore: cleanups6
pieh 05fd540
Merge remote-tracking branch 'origin/main' into blob-test-variants
pieh 2489637
chore: cleanups7
pieh 548b092
chore: test basePath
pieh 57e9bb3
chore: test basePath, no i18n
pieh 5d3d456
chore: test no basePath no i18n
pieh 4850a9d
chore: restore default demo config
pieh a81452b
chore: cleanups8
pieh 84d020b
test: fix unit tests, maybe fix API functions
pieh 4662234
test: maybe fix API functions2
pieh 316ca06
chore: try to make fallback:true act as fallback:blocking
pieh 30cdeb0
chore: fix some logic in fallback: blocking forcing and add comments
pieh 01d3058
chore: update test comments
pieh 3074b31
chore: move some imports so comment make sense
pieh b38586d
chore: strip node: from compiled @netlify/blobs
pieh d5b818a
chore: restore revalidation on non-first odb request
pieh 4027de1
chore: add a feature flag for using blobs for isr pages
pieh c9e173c
chore: sync package-lock.json
pieh b704128
Merge remote-tracking branch 'origin/main' into nickytonline/blob-sto…
pieh 239e044
fix: import type from package entry and not internals
pieh 563a189
Merge remote-tracking branch 'origin/main' into nickytonline/blob-sto…
pieh 3f3deb1
Merge remote-tracking branch 'origin/main' into nickytonline/blob-sto…
pieh 12c4723
chore: bump @netlify/blobs, don't build CJS version anymore
pieh ff4d8c5
Merge remote-tracking branch 'origin/main' into nickytonline/blob-sto…
pieh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually not changing any assertions, just update the comment why the assertions will stay as they are. Visiting https://651d4678cf52d90008b40118--netlify-plugin-nextjs-demo.netlify.app/getStaticProps/withRevalidate/withFallback/3/ (older preview) shows the problematic behavior (that fallback that flashes before browser client update) - you can also just check with JS disabled in browser and then you never get to see actual proper content