Skip to content

Commit

Permalink
chore: use netlify-cli as a regular dev dep
Browse files Browse the repository at this point in the history
Instead of adding nondeterminism to our CI by installing netlify-cli@latest on each run, just
install it as a regular dev dep and let Renovate handle bumps.

In the case of the next.js repo e2e tests, reference this repo (which is guaranteed to be a sibling
directory) to access the netlify-cli binary.
  • Loading branch information
serhalp committed Jun 14, 2024
1 parent 850ee8a commit 4a5a2eb
Show file tree
Hide file tree
Showing 5 changed files with 41,693 additions and 12,525 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ jobs:
env:
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
run: |
# TODO(serhalp) Unpin version once
# https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
npm i -g [email protected]
netlify login
- name: Get installed Playwright version
id: playwright-version
Expand Down Expand Up @@ -208,9 +205,6 @@ jobs:
env:
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
run: |
# TODO(serhalp) Unpin version once
# https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
npm i -g [email protected]
netlify login
- name: Resolve Next.js version
id: resolve-next-version
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,6 @@ jobs:
run: npm run build
working-directory: ${{ env.runtime-path }}

- name: add netlify cli
run: npm install -g netlify-cli

- name: Install Playwright Browsers
run: npx playwright install --with-deps
working-directory: ${{ env.next-path }}
Expand Down
Loading

0 comments on commit 4a5a2eb

Please sign in to comment.