SDK-342 - SDK fails if distro.properties supplies type or group for c… #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wikumChamith
reviewed
Nov 8, 2024
| @@ -154,9 +154,14 @@ public List<Artifact> getContentArtifacts() { | |||
| List<Artifact> artifacts = new ArrayList<>(); | |||
There was a problem hiding this comment.
@mseaton wouldn't it be better to consolidate duplicated code for extracting different artifact types into a single reusable method?
Suggested change
| List<Artifact> artifacts = new ArrayList<>(); | |
| public List<Artifact> getWarArtifacts(){ | |
| return getArtifacts(TYPE_WAR); | |
| } | |
| public List<Artifact> getConfigArtifacts() { | |
| return getArtifacts(TYPE_CONFIG); | |
| } | |
| public List<Artifact> getContentArtifacts() { | |
| return getArtifacts(TYPE_CONTENT); | |
| } | |
| private List<Artifact> getArtifacts(String typeContent) { | |
| List<Artifact> artifacts = new ArrayList<>(); | |
| for (Object keyObject : getAllKeys()) { | |
| String key = keyObject.toString(); | |
| String artifactType = getArtifactType(key); | |
| if (artifactType.equals(typeContent)) { | |
| artifacts.add(new Artifact( | |
| checkIfOverwritten(key, ARTIFACT_ID), | |
| getParam(key), | |
| checkIfOverwritten(key, GROUP_ID), | |
| checkIfOverwritten(key, TYPE) | |
| )); | |
| } | |
| } | |
| return artifacts; | |
There was a problem hiding this comment.
Indeed @wikumChamith there are many, many opportunities to work on tech debt in the SDK. This initial PR is attempting to just fix the underlying issue. More than happy to make broader refactoring improvements in other commits / tickets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ontent package
see https://openmrs.atlassian.net/browse/SDK-342