Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTWS-963: Add a swagger autogeneration util to scan through resource handlers and generate the swagger spec #638

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mherman22
Copy link
Member

@mherman22 mherman22 commented Dec 3, 2024

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-963

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@dkayiwa
Copy link
Member

dkayiwa commented Dec 3, 2024

It is a recommended practice to include the ticket id in the commit message.

@mherman22 mherman22 requested a review from dkayiwa December 5, 2024 17:54
@dkayiwa
Copy link
Member

dkayiwa commented Dec 6, 2024

I was not expecting the new approach to change any existing methods. I expected to only inspect the resources to do the needful without touching them in any way.

@mherman22
Copy link
Member Author

I was not expecting the new approach to change any existing methods. I expected to only inspect the resources to do the needful without touching them in any way.

it doesn't change any existing method, to get this working i have to make changes within SwaggerSpecificationCreator.java. Except for the @Deprecated method, i am gonna add that back.

@Override
public Model getGETModel(Representation rep) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is mainly to fix the test that depends on this class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants