Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTWS-962: Return empty result when the specified encounter type is not found #636

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

icrc-psousa
Copy link
Contributor

@icrc-psousa icrc-psousa commented Nov 22, 2024

Description of what I changed

Return empty result when the specified encounter type is not found

Issue I worked on

see https://openmrs.atlassian.net/browse/RESTWS-962

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@coveralls
Copy link

Coverage Status

coverage: 47.704%. remained the same
when pulling 1d87eba on fix/encountertype-search-handling
into 9786f8d on master.

@icrc-psousa icrc-psousa changed the title RESTWS-962: Return empty results for invalid or unauthorized encounter type search RESTWS-962: Return empty result when the specified encounter type is not found Dec 10, 2024
@ibacher ibacher merged commit 9499895 into master Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants