TRUNK-6203: Global properties access should be privileged #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
May 29, 2024
| @@ -210,8 +211,16 @@ public static boolean ipMatches(String ip, List<String> candidateIps) { | |||
| * @return the list of IPs | |||
| */ | |||
| public static List<String> getAllowedIps() { | |||
There was a problem hiding this comment.
This is called before accessing the O3 login page.
dkayiwa
reviewed
May 29, 2024
| String allowedIpsProperty = ""; | ||
| try { | ||
| Context.addProxyPrivilege("Get Global Properties"); | ||
| allowedIpsProperty = Context.getAdministrationService() |
There was a problem hiding this comment.
Can you just pass allowedIpsProperty as the second argument.
dkayiwa
reviewed
May 29, 2024
| .getGlobalProperty(RestConstants.ALLOWED_IPS_GLOBAL_PROPERTY_NAME, ""); | ||
| String allowedIpsProperty = ""; | ||
| try { | ||
| Context.addProxyPrivilege("Get Global Properties"); |
There was a problem hiding this comment.
Why not use PrivilegeConstants?
There was a problem hiding this comment.
PrivilegeConstants.GET_GLOBAL_PROPERTIES is not available in the platform version that this module uses
|
@dkayiwa I updated this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
After openmrs/openmrs-core#4601, users must possess the 'Get Global Properties' privilege to access global properties. This grants it as a proxy privilege so users can access essential pages, such as the login page.
Issue I worked on
see https://openmrs.atlassian.net/browse/TRUNK-6203
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master