RESTWS-925: Session endpoint 'user.person.display' should respect the name template. #607
Conversation
|
@brandones @dkayiwa @ibacher could you please review this PR, your feedback will be appreciated. |
|
@IamMujuziMoses is there a reason why you do not want this to be available for lower versions of the platform? |
|
@dkayiwa I tried making it available prior, but let me try again🙂 |
@dkayiwa in order for the session endpoint |
|
Platform 2.7.0 just added the ability to customise it via a global property. But the session end point should still respect even the default name template. |
|
Ohh, okay, let me work on it🙂 |
|
@dkayiwa I have pushed an updated commit, please take a look. |
|
I'm closing this PR because, to the best of my knowledge, this feature is already implemented. See the comment here. |
Issue I worked on
see https://issues.openmrs.org/browse/RESTWS-925
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master