Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTWS-925 Edited the nameTemplate #603

Closed
wants to merge 2 commits into from

Conversation

suubi-joshua
Copy link

@suubi-joshua suubi-joshua commented Apr 3, 2024

Description of what I changed

Update the layout.name.format Global Property to the custom template's codeName so that it is chosen as the active template.

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-925

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@brandones brandones requested a review from dkayiwa April 3, 2024 14:17
@brandones
Copy link
Contributor

@dkayiwa I don't know what this change does, but it's supposed to fix https://openmrs.atlassian.net/browse/RESTWS-925 . Do you think this is the right approach? Obviously, if it is, we will need the PR cleaned up a lot, some demonstration that it actually works, etc. But would be nice to know if the solution makes sense in the first place.

@dkayiwa
Copy link
Member

dkayiwa commented Apr 3, 2024

@suubi-joshua the ticket is not about editing the name template. But rather getting the user.person.display returned by the session end point to use the currently configured name template. When done with this ticket, you will need to attach data returned by this endpoint to prove that you have actually fixed the reported issue.

@suubi-joshua
Copy link
Author

suubi-joshua commented Apr 8, 2024

@dkayiwa Is there documentation on how I can test out my changes for the rest module locally. To see if what I have done produces the intended changes.

@dkayiwa
Copy link
Member

dkayiwa commented Apr 9, 2024

@suubi-joshua did you try dropping the compiled module into the modules folder and restart openmrs?

@suubi-joshua
Copy link
Author

@suubi-joshua did you try dropping the compiled module into the modules folder and restart openmrs?

Yes I have done so using openmrs-core, the module builds successfully.
But am still wondering how I can access the session end point data.

@dkayiwa
Copy link
Member

dkayiwa commented Apr 10, 2024

By simply accessing the session end point url that i shared above.

@suubi-joshua
Copy link
Author

@suubi-joshua did you try dropping the compiled module into the modules folder and restart openmrs?

Yes I have done so using openmrs-core, the module builds successfully.
But am still wondering how I can access the session end point data.

By simply accessing the session end point url that i shared above.

Yes I have tried this but its giving me a 404 error. But am trying again to see if I did something wrong.

@brandones brandones closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants