Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTWS-933: Revert RESTWS-901 due to issue saving coded pt attrs #600

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

icrc-fdeniger
Copy link
Contributor

@icrc-fdeniger icrc-fdeniger commented Mar 15, 2024

The PR done with RESTWS-901 introduced a regression in the patient registration steps.
If concepts are used for some attributes ( civil status) there are now saved with their uuid in the database ( table person_attribute) and no more with the concept_id.

… (#581)"

This reverts commit cbcf07f.

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-933

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@icrc-fdeniger icrc-fdeniger changed the title RESTWS-933 [Urgent] RESTWS-933 concepts used in person_attribute are saved with their uuid Mar 15, 2024
@icrc-fdeniger
Copy link
Contributor Author

@k4pran this PR will revert a commit that introduced some side effect on the patient registration.
For sure we can try to fix it correcty but as we deployed it in prod ( and we need the last version for other bugfixes) we propose to revert the commit.

@icrc-fdeniger icrc-fdeniger requested review from k4pran and ibacher March 15, 2024 16:25
Copy link
Contributor

@k4pran k4pran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes looks like this reverts the change correctly

@ibacher ibacher changed the title [Urgent] RESTWS-933 concepts used in person_attribute are saved with their uuid RESTWS-933: Revert RESTWS-901 due to issue saving coded pt attrs Mar 15, 2024
@ibacher ibacher merged commit 6d01f5f into openmrs:master Mar 15, 2024
1 check passed
@icrc-fdeniger icrc-fdeniger deleted the RESTWS-933 branch March 15, 2024 17:21
@icrc-fdeniger
Copy link
Contributor Author

thanks @k4pran . Do you believe we can do a release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants