RESTWS-907: Cannot search for inactive drug orders in RefApp 3.x #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Sep 23, 2023
| import java.util.List; | ||
| import java.util.ListIterator; | ||
| import java.util.Map; | ||
| import java.util.stream.Collectors; |
There was a problem hiding this comment.
Where are you using the above import?
dkayiwa
reviewed
Sep 23, 2023
| import java.util.List; | ||
| import java.util.ListIterator; |
There was a problem hiding this comment.
Where are you using the above import?
ibacher
reviewed
Oct 4, 2023
| * @param delegate the object that simple represents | ||
| */ | ||
|
|
||
| private void maybeDecorateWithStatus(SimpleObject simple, T delegate) { |
There was a problem hiding this comment.
Is there a reason to have this kind of class-specific logic here instead of in, say, an order-focused endpoint? This seems very hacky...
ibacher
reviewed
Oct 4, 2023
| * @param checkDate to check against the order.autoExpireDate | ||
| * @return boolean true or false if the order.autoExpireDate is passed or not | ||
| */ | ||
| private boolean isExpired(Order order, Date checkDate) { |
IamMujuziMoses
force-pushed
the
RESTWS-907
branch
3 times, most recently
from
1a4d49a to
d1091f5
Compare
IamMujuziMoses
force-pushed
the
RESTWS-907
branch
from
d1091f5 to
796fef7
Compare
IamMujuziMoses
commented
Oct 5, 2023
| * @return Status | ||
| */ | ||
| @PropertyGetter("status") | ||
| public String getStatus(Order order) { |
There was a problem hiding this comment.
@ibacher, how about something like this?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue I worked on
see https://issues.openmrs.org/browse/RESTWS-907
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master