META-241: Display xml for the assessed items when user wants to compare in detail #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Nov 28, 2019
| return new String(((ByteArrayOutputStream)res.getOutputStream()).toByteArray()); | ||
|
|
||
| } catch(Exception e) { | ||
| return xml; |
There was a problem hiding this comment.
Are you intentionally ignoring this exception?
There was a problem hiding this comment.
Let me handle it...Thanks
reagan-meant
force-pushed
the
META-241
branch
from
b8d0a76 to
2a07074
Compare
|
@reagan-meant do you still have the time to take this to the finishing line? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Craeted a dialog table that enables user to preview the incoming and existing metadata in detail when the user clicks the Compare in detail button.
https://issues.openmrs.org/browse/META-241