EA-209 fix date comparison in getMothersAndChildren() to determine wh…

[chibongho]

…ether child is born during mother's visit

See: https://openmrs.atlassian.net/browse/EA-209

[chibongho]

I don't like this manual concatenation, but I can't find a DATE() function in hql like in mysql.

[mseaton]

Ick, ugly, but it was also ugly before.

[chibongho]

A bit moot, but looks like later version of hql has something saner:

extract(date from child.birthdate)

https://docs.jboss.org/hibernate/orm/6.6/userguide/html_single/Hibernate_User_Guide.html

[mogoodrich]

Oh, thanks @chibongho , yeah, whoops, bug on my part, nice catch. The string concanetation is ugly, but if we are assured that the greater than test will always work correctly, I guess we are okay.

The other option would be to be more explicit about the day/month/year comparisions, we could do this, right (admittedly "wordy", and I probably have my parathesis wrong, hard to match up outside of an editor)?

and (year(child.birthdate) >= year(motherVisit.startDatetime) or 

(year(child.birthdate) == year(motherVisit.startDatetime) and month(child.birthdate) >= month(motherVisit.startDatetime)) or

(year(child.birthdate) == year(motherVisit.startDatetime) and month(child.birthdate) == month(motherVisit.startDatetime)) and day(child.birthdate) >= day(motherVisit.startDatetime))