Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EA-194: REST API url should have same standard prefix as other REST e… #234

Merged
merged 1 commit into from
Jul 11, 2024
Merged

EA-194: REST API url should have same standard prefix as other REST e… #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion omod/src/main/java/org/openmrs/module/emrapi/web/controller/ActiveVisitController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
* (Currently only supports "ensureActiveVisit")
*/
@Controller
@RequestMapping(value = "/rest/emrapi/activevisit")
@RequestMapping(value = "/rest/**/emrapi/activevisit")
public class ActiveVisitController extends BaseRestController {

@Autowired
Expand Down
2 changes: 1 addition & 1 deletion omod/src/main/java/org/openmrs/module/emrapi/web/controller/DiagnosisController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import org.springframework.web.bind.annotation.ResponseBody;

@Controller
@RequestMapping(value = "/rest/emrapi")
@RequestMapping(value = "/rest/**/emrapi")
public class DiagnosisController extends BaseRestController {

@Autowired
Expand Down
2 changes: 1 addition & 1 deletion ...src/main/java/org/openmrs/module/emrapi/web/controller/EmrApiConfigurationController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import javax.servlet.http.HttpServletResponse;

@Controller
@RequestMapping(value = "/rest/emrapi/configuration")
@RequestMapping(value = "/rest/**/emrapi/configuration")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't been released, so in theory we could just use v1, but this makes sense regardless I think until there is actually a v2+

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I'm just going to merge this in, but feel free to change when you finalize your PR

public class EmrApiConfigurationController {

@Autowired
Expand Down
2 changes: 1 addition & 1 deletion omod/src/main/java/org/openmrs/module/emrapi/web/controller/EmrConceptSearchController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
import static org.springframework.web.bind.annotation.ValueConstants.DEFAULT_NONE;

@Controller
@RequestMapping(method = RequestMethod.GET, value = "/rest/emrapi/concept")
@RequestMapping(method = RequestMethod.GET, value = "/rest/**/emrapi/concept")
public class EmrConceptSearchController {
@Autowired
EmrApiProperties emrApiProperties;
Expand Down
2 changes: 1 addition & 1 deletion omod/src/main/java/org/openmrs/module/emrapi/web/controller/EmrEncounterController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import java.util.List;

@Controller
@RequestMapping(value = "/rest/emrapi/encounter")
@RequestMapping(value = "/rest/**/emrapi/encounter")
public class EmrEncounterController extends BaseRestController {

@Autowired
Expand Down
2 changes: 1 addition & 1 deletion omod/src/main/java/org/openmrs/module/emrapi/web/controller/InpatientVisitsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import org.springframework.web.bind.annotation.ResponseBody;

@Controller
@RequestMapping(value = "/rest/emrapi/inpatient")
@RequestMapping(value = "/rest/**/emrapi/inpatient")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. Not really an issue, as I think this controller / endpoint is going to go away once my PR is ready...

public class InpatientVisitsController {

@Autowired
Expand Down
Loading