EA-179: Fix Locale issue while saving Medication #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Dec 8, 2023
| return null; | ||
| } | ||
|
|
||
| public Concept getDispenseUnitsConceptByName(String conceptName) { |
There was a problem hiding this comment.
Is there any reason why you did not call this getQuantityUnits?
There was a problem hiding this comment.
Since the API method we are setting calls it quantity units, when you called it dispense units, i thought you were using it for something else.
There was a problem hiding this comment.
No specific reason. I choose name dispense units because we are making use of getDrugDispensingUnits from orderservice. If u want this method called as getQuantityUnits, I can change it.
dkayiwa
reviewed
Dec 8, 2023
| import java.util.Locale; | ||
|
|
||
| import static org.hamcrest.core.Is.is; | ||
| import static org.junit.Assert.assertNull; | ||
| import static org.junit.Assert.assertThat; | ||
| import static org.junit.Assert.*; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for pointing out. Done. replaced with single class imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openmrs.atlassian.net/jira/software/c/projects/EA/issues/EA-179