-
Notifications
You must be signed in to change notification settings - Fork 143
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
4b2056e
commit 36e524e
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36e524e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mseaton can you sanity check this one for me? This test was failing (I believe) when run between midnight and 1am (which on the CI services, in UTC, corresponds to 8pm to 9pm EDT) because "one hour ago" was the same day as one day ago.
This fixes the test but can you confirm this doesn't break what you were trying to test?
36e524e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me @mogoodrich . AFAICT, you authored this originally and have been the only committer to it, so this isn't something I had any original designs on.
36e524e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duh, thanks @mseaton !