(Fix) FIxed the view all tabs on stock management dashboard , under inventory alerts, issuing and receiving #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabahum
requested changes
Dec 16, 2024
| ]; | ||
|
|
||
| return ( | ||
| <Modal |
There was a problem hiding this comment.
lets use the stick to using the openmrs/esm-framework utilities for modal creation and management
| </p> | ||
| </div> | ||
| </div> | ||
| ))} | ||
| <Button | ||
| {/* <Button |
There was a problem hiding this comment.
lets clean out on unused code if its nolonger necessary
| @@ -64,7 +67,7 @@ const StockHomeIssuingCard = () => { | |||
| </div> | |||
| </div> | |||
| ))} | |||
| <Button | |||
| {/* <Button | |||
| </Button> | ||
|
|
||
| <IssuingStockModal open={isModalOpen} onClose={() => setModalOpen(false)} issuingStock={items} /> |
There was a problem hiding this comment.
lets use openmrs/esm-framework modal utilities
|
Thanks for the work @samsonmwanzia! Please create a ticket and also share some screenshots/video. |
|
welcome i will send the video/screenshot tomorrow
…On Mon, 16 Dec 2024 at 20:46, Makombe Kennedy ***@***.***> wrote:
Thanks for the work @samsonmwanzia <https://github.com/samsonmwanzia>!
Please create a ticket and also share some screenshots/video.
—
Reply to this email directly, view it on GitHub
<#248 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJIUPZL7ZEH3BYPQLD7F5TT2F4GXVAVCNFSM6AAAAABTRZDE6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBWGI3DIMZSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Screencast.2024-12-17.11.56.03.mp4cleaned unused code too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Fix the view all tabs on stock management dashboard under inventory alerts , issuing and receiving cards.
Screenshots
Related Issue
Other