-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) O3-4226: Bump @carbon/react to v1.71.0 #2124
base: main
Are you sure you want to change the base?
Conversation
@Muta-Jonathan I fixed one of the tests by fixing the Regex we had used and by adding a stub for
adding the Lines 89 to 91 in 1d717fa
would give you a url that when you open in the browser would give you a playground. The regex in the query box is what I used to update the test case. |
thanks @NethmiRodrigo @denniskigen this worked ... ready for review |
Can you update your branch @Muta-Jonathan? |
@Muta-Jonathan could you please update your branch and fix the failing e2e tests? Please do let me know if you need any guidance on fixing the e2e test |
indeed @NethmiRodrigo talked to @denniskigen yesterday on the coffe-break it seems it is breaking due to changes he did in the meta-Data probably.. but if we can look into the solution the better |
On a side note, @ibacher should this go in after the carbon upgrade in core? |
It shouldn't matter too much. However, we may need to update the patient-management before merging this. |
Requirements
Summary
This PR upgrades carbon to the latest version 1.71.0. Release notes at https://carbondesignsystem.com/migrating/guide/develop/
Related Issue
Bump carbon version in Patient Chart