Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) O3-4226: Bump @carbon/react to v1.71.0 #2124

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Muta-Jonathan
Copy link
Member

@Muta-Jonathan Muta-Jonathan commented Dec 1, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR upgrades carbon to the latest version 1.71.0. Release notes at https://carbondesignsystem.com/migrating/guide/develop/

Related Issue

Bump carbon version in Patient Chart

@NethmiRodrigo NethmiRodrigo self-requested a review December 2, 2024 05:52
@NethmiRodrigo
Copy link
Collaborator

@Muta-Jonathan I fixed one of the tests by fixing the Regex we had used and by adding a stub for scrollIntoView function - jsdom/jsdom#1695. Please use that as reference to fix the remaining failing unit tests, you can use screen.logTestingPlaygroundURL(); in the middle of a test case to see what roles are accessible and for seeing how a regex needs to be updated. For example, in the visits-table.test.stx, for the failing test case Delete encounter > Clicking the Delete button deletes an encounter that gives the error

Unable to find an accessible element with the role "row" and name /18-Jan-2022, 04:25 PM Facility Visit Admission POC Consent Form -- Options/i

adding the screen.logTestingPlaygroundURL(); right before the line where you get the error
(which is line number 89) -

const row = screen.getByRole('row', {
name: /18-Jan-2022, 04:25 PM Facility Visit Admission POC Consent Form -- Options/i,
});

would give you a url that when you open in the browser would give you a playground. The regex in the query box is what I used to update the test case.
Screenshot 2024-12-02 at 2 24 41 PM

@NethmiRodrigo NethmiRodrigo changed the title (chore) Bump @carbon/react to v1.71.0 (chore) O3-4226: Bump @carbon/react to v1.71.0 Dec 9, 2024
@Muta-Jonathan
Copy link
Member Author

thanks @NethmiRodrigo @denniskigen this worked ... ready for review

@NethmiRodrigo
Copy link
Collaborator

Can you update your branch @Muta-Jonathan?

@NethmiRodrigo
Copy link
Collaborator

@Muta-Jonathan could you please update your branch and fix the failing e2e tests? Please do let me know if you need any guidance on fixing the e2e test

@Muta-Jonathan
Copy link
Member Author

Muta-Jonathan commented Dec 11, 2024

indeed @NethmiRodrigo talked to @denniskigen yesterday on the coffe-break it seems it is breaking due to changes he did in the meta-Data probably.. but if we can look into the solution the better

@NethmiRodrigo
Copy link
Collaborator

On a side note, @ibacher should this go in after the carbon upgrade in core?

@ibacher
Copy link
Member

ibacher commented Dec 11, 2024

On a side note, @ibacher should this go in after the carbon upgrade in core?

It shouldn't matter too much. However, we may need to update the patient-management before merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants