(feat) Restore ability to collapse and expand the entire form #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -252 kB (-17.07%) 👏 Total Size: 1.22 MB
ℹ️ View Unchanged
|
denniskigen
reviewed
Oct 16, 2024
Comment on lines
61
to
66
| <CollapsibleSectionContainer | ||
| section={section} | ||
| sectionIndex={index} | ||
| visibleSections={visibleSections} | ||
| isFormExpanded={isFormExpanded} | ||
| /> |
There was a problem hiding this comment.
Suggested change
| <CollapsibleSectionContainer | |
| section={section} | |
| sectionIndex={index} | |
| visibleSections={visibleSections} | |
| isFormExpanded={isFormExpanded} | |
| /> | |
| <CollapsibleSectionContainer | |
| key={`section-${section.label}`} | |
| section={section} | |
| sectionIndex={index} | |
| visibleSections={visibleSections} | |
| isFormExpanded={isFormExpanded} | |
| /> |
| <SectionRenderer section={section} /> | ||
| </div> | ||
| </AccordionItem> | ||
| {visibleSections.map((section, index) => ( |
There was a problem hiding this comment.
Unrelated to your changes, but maybe visibleSections could benefit from memoization:
const visibleSections = useMemo(() => {
return page.sections.filter((section) => {
const hasVisibleQuestions = section.questions.some((question) => !isTrue(question.isHidden));
return !isTrue(section.isHidden) && hasVisibleQuestions;
});
}, [page.sections]);| @@ -42,25 +55,51 @@ function PageRenderer({ page }: PageRendererProps) { | |||
| </span> | |||
| </p> | |||
| </div> | |||
| {!isCollapsed && ( | |||
| <div className={isCollapsed ? styles.hiddenAccordion : styles.accordionContainer}> | |||
There was a problem hiding this comment.
Suggested change
| <div className={isCollapsed ? styles.hiddenAccordion : styles.accordionContainer}> | |
| <div className={classNames({ | |
| [styles.hiddenAccordion]: isCollapsed, | |
| [styles.accordionContainer]: !isCollapsed | |
| })}> |
| [styles.firstSection]: sectionIndex === 0, | ||
| [styles.lastSection]: sectionIndex === visibleSections.length - 1, | ||
| })} | ||
| key={`section-${section.label}`}> |
There was a problem hiding this comment.
Suggested change
| key={`section-${section.label}`}> | |
| > |
denniskigen
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR primarily restores the ability to collapse and expand all visible form pages and sections.
Out of scope:
Screenshots
Unmounting Issue:
(The Encounter Provider and Location fields are remounted)
Unmounting Issue Fixed:
Other features:
Related Issue
N/A
Other
Note: Carbon doesn't support nesting accordions, which is why I resorted to manipulating the visibility of the sections during page collapse; see: