Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Use unique React keys in the multi-select component #410

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

samuelmale
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes an issue were questions (checkbox rendering) with the same concept answers conflict. It fixes the bug by using unique React keys for the underlying components.

Screenshots

2024-10-10 16-37-09 2024-10-10 16_38_15

Related Issue

https://openmrs.atlassian.net/browse/O3-4076

Other

@samuelmale samuelmale changed the title (fix) Ensure that we use unique React keys in the multi-select component (fix) Use unique React keys in the multi-select component Oct 10, 2024
Copy link

Size Change: +4 B (0%)

Total Size: 1.22 MB

ℹ️ View Unchanged
Filename Size Change
dist/151.js 378 kB 0 B
dist/225.js 2.57 kB 0 B
dist/277.js 1.84 kB 0 B
dist/300.js 642 B 0 B
dist/335.js 968 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.37 kB 0 B
dist/420.js 108 kB 0 B
dist/422.js 6.8 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 758 B 0 B
dist/617.js 86.9 kB 0 B
dist/635.js 14.3 kB 0 B
dist/70.js 483 B 0 B
dist/751.js 252 kB +3 B (0%)
dist/901.js 11.8 kB 0 B
dist/99.js 691 B 0 B
dist/993.js 3.09 kB 0 B
dist/main.js 342 kB +1 B (0%)
dist/openmrs-esm-form-engine-lib.js 3.67 kB 0 B

compressed-size-action

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pirupius pirupius merged commit 810fd93 into main Oct 11, 2024
4 checks passed
@pirupius pirupius deleted the fix/useUniqueReactKeyForCheckbox branch October 11, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants