(test) O3-3937 Add test coverage around form readonly mode #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.22 MB ℹ️ View Unchanged
|
samuelmale
reviewed
Sep 25, 2024
CynthiaKamau
force-pushed
the
O3-3937
branch
4 times, most recently
from
7a498c2 to
8f30422
Compare
samuelmale
requested changes
Oct 14, 2024
src/form-engine.test.tsx
Outdated
| @@ -842,15 +844,68 @@ describe('Form engine component', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| function renderForm(formUUID, formJson, intent?: string) { | |||
| describe('Read only mode', () => { | |||
| it('should ascertain that each field with readonly = true passed will not be editable', async () => { | |||
There was a problem hiding this comment.
Suggested change
| it('should ascertain that each field with readonly = true passed will not be editable', async () => { | |
| it('should ensure that each read-only field is not editable', async () => {', async () => { |
src/form-engine.test.tsx
Outdated
| }); | ||
|
|
||
| describe('Form view mode', () => { | ||
| it('should ascertain that fields cannot be edited on view mode', async () => { |
There was a problem hiding this comment.
Suggested change
| it('should ascertain that fields cannot be edited on view mode', async () => { | |
| it('should ensure that the form isn't editable in view mode', async () => { |
Comment on lines
+891
to
+880
| inputs.forEach((input) => { | ||
| expect(input).toHaveAttribute('readonly'); | ||
| }); |
There was a problem hiding this comment.
Can you also assert that the "Save" button is disabled?
There was a problem hiding this comment.
Added it on line 884
Comment on lines
+130
to
+138
| { | ||
| id: 'sampleQuestion', | ||
| label: 'Question title', | ||
| questionOptions: { | ||
| concept: '193e8a03-1581-46e9-b0a4-17c55fa2649f', | ||
| rendering: 'text', | ||
| }, | ||
| type: 'obs', | ||
| }, |
Comment on lines
+258
to
+266
| { | ||
| id: 'sampleQuestion', | ||
| label: 'Question title', | ||
| questionOptions: { | ||
| concept: '193e8a03-1581-46e9-b0a4-17c55fa2649f', | ||
| rendering: 'text', | ||
| }, | ||
| type: 'obs', | ||
| }, |
There was a problem hiding this comment.
Removing this block brings this error
src/form-engine.test.tsx
Outdated
| expect(visitTypeDropdown).toHaveClass('cds--list-box__field'); | ||
|
|
||
| const visitTypeWrapper = visitTypeDropdown.closest('.cds--dropdown'); | ||
| expect(visitTypeWrapper).toHaveClass('cds--dropdown cds--dropdown--readonly cds--list-box'); |
There was a problem hiding this comment.
What happens if the CSS names change? Can you use attributes instead?
samuelmale
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
O3-3937 Add test coverage around form readonly mode
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3937
Other