Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Enhance support for "checkbox" rendering #400

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

samuelmale
Copy link
Member

@samuelmale samuelmale commented Sep 24, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This pull request aims to enhance the rendering options for checkboxes by supporting two distinct types: checkbox and checkbox-searchable.

Changes Made:

  • Rendering Types:
    • The checkbox type will render the conventional checkbox group.
    • The checkbox-searchable type will render a compact version (combo-box)
  • Backward Compatibility:
    • To maintain backward compatibility, the multiCheckbox property will default to the checkbox-searchable rendering type. If the inlineMultiCheckbox property is present and set to true, it will be mapped to the checkbox rendering type

Screenshots

Checkbox rendering:
Screenshot 2024-09-24 at 16 49 41

Checkbox searchable:
Screenshot 2024-09-24 at 16 51 21

multiCheckbox:
Screenshot 2024-09-24 at 16 52 36

multiCheckbox with inlineMultiCheckbox set to true
Screenshot 2024-09-24 at 16 53 43

Related Issue

https://openmrs.atlassian.net/browse/O3-3831

Other

Copy link

Size Change: +83 B (+0.01%)

Total Size: 1.15 MB

ℹ️ View Unchanged
Filename Size Change
dist/151.js 300 kB 0 B
dist/225.js 2.57 kB 0 B
dist/277.js 1.84 kB 0 B
dist/300.js 642 B 0 B
dist/335.js 968 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.37 kB 0 B
dist/422.js 6.8 kB 0 B
dist/501.js 108 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 758 B 0 B
dist/572.js 252 kB +80 B (+0.03%)
dist/617.js 86.9 kB 0 B
dist/635.js 14.3 kB 0 B
dist/70.js 483 B 0 B
dist/901.js 11.8 kB 0 B
dist/99.js 691 B 0 B
dist/993.js 3.09 kB 0 B
dist/main.js 342 kB +3 B (0%)
dist/openmrs-esm-form-engine-lib.js 3.67 kB 0 B

compressed-size-action

Copy link
Member

@usamaidrsk usamaidrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samuelmale
This LGTM,

@samuelmale samuelmale merged commit 8e9ae10 into main Sep 25, 2024
4 checks passed
@samuelmale samuelmale deleted the feat/checkboxRendering branch September 25, 2024 19:50
@denniskigen
Copy link
Member

@gracepotma Check this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants