(feat): O3-3685: Enable Deleting or Clearing Files in File Picker Component in Edit Mode #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmale
requested changes
Sep 18, 2024
|
Thanks for this @TrevorAntony. LGTM. |
|
@TrevorAntony The "Clear File" button seems to be overlapped by the side rail. I think we should have an actions menu associated with the file itself, or we could simply place the delete button next to the attachment. This is important considering that we plan to support capturing multiple attachments. Feel free to ask for some UX advisory if necessary. 
|
|
@TrevorAntony are you still working on this? |
|
@samuelmale Not at the moment. |
ibacher
changed the title
|
@TrevorAntony Are you planning to pick this back up, and if so, when? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
When a file is selected using the file picker component and the form is later opened in edit mode, there is currently no option to delete or clear the selected file.
Summary
The user can now successfully edit an encounter and add or remove an image/file by clearing it.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3685
Other
the delete persists on form submission and reloading