(feat) adding support for questionInfo #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirupius
reviewed
Dec 12, 2023
Comment on lines
46
to
55
| <div className={styles.tooltipWithUnspecified}> | ||
| <OHRIUnspecified question={field} onChange={onChange} handler={formFieldHandlers[field.type]} /> | ||
| {field.questionInfo && <OHRITooltip field={field} />} | ||
| </div> | ||
| </div> | ||
| ) : ( | ||
| questionFragment | ||
| <div className={styles.parent}> | ||
| {questionFragment} | ||
| <div className={styles.tooltip}>{field.questionInfo && <OHRITooltip field={field} />}</div> | ||
| </div> |
There was a problem hiding this comment.
Having 2 different references looks unnecessary. This can be condensed by renaming the class to some thing more generic and then adding the check only to show the Tooltip component
Comment on lines
54
to
57
| <div className={styles.tooltipWithUnspecified}> | ||
| <OHRIUnspecified question={fieldDescriptor} onChange={onFieldChange} handler={handler} /> | ||
| {fieldDescriptor.questionInfo && <OHRITooltip field={fieldDescriptor} />} | ||
| </div> |
There was a problem hiding this comment.
same comment applies here about drying this out
There was a problem hiding this comment.
This has been resolved.
pirupius
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds support for rendering a tooltip which gives the user more information about a field within the React Form Engine.
Screenshots
Related Issue
Other