Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Enhance User Experience with MUI Datepicker #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

icrc-jofrancisco
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

This PR addresses user feedback regarding the usability of datepicker switch buttons, particularly on small devices. By switching to MUI's datepicker provider, we improve user-friendliness by offering larger, more accessible buttons for switching dates.
Although switching to MUI's datepicker, we maintain a similar visual style while significantly improving usability.
This change ensures a smoother navigation experience, especially on mobile devices, and aligns with our commitment to enhancing usability across our application.

Key Advantages:

  • Larger, more accessible switch buttons for improved usability
  • Enhanced user experience on small devices

Screenshots

Before:
image

After:

datepicker

Related Issue

Other

CC: @ibacher

Copy link

@IamSAL IamSAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a whole new design system library like MUI for one feature is not recommended, as it'll increase the bundle size.

also using multiple design systems can lead to inconsistent look on the overall UI. The project already has 'carbondesignsystem' installed.

is there any way to customize the existing date picker without introducing new library?

@@ -92,9 +92,16 @@
"webpack-cli": "^5.1.4"
},
"dependencies": {
"@emotion/react": "^11.11.4",
"@emotion/styled": "^11.11.0",
"@mui/material": "^5.15.12",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a whole new design system library lik MUI for one feature is not recommended, as it'll increase the bundle size.

also using multiple design systems can lead to inconsistent look on the overall UI. The project already has 'carbondesignsystem' installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IamSAL . I fully understand your point! I don't think there's much of a solution that differs from this one, because the dote picker needs the style that's only in these packages. any suggestions?

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants