Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Page header redesign #129

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Dec 3, 2024

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Redesigns the dispensing app page header to reuse the PageHeader, PageHeaderContent, and PharmacyPictogram components from Core.

Screenshots

Before

dispensing-header-current

After

dispensing-header-redesign

Key changes:

  • Replaced the custom illustration in the page header with the standardized pharmacy pictogram from Core
  • Added a 1px solid gray bottom border to the header for better visual separation
  • Added a 1rem vertical border to the page content to create a floating tab effect, better matching the design spec

Related Issue

Other

Redesigns the dispensing app page header to reuse the PageHeader, PageHeaderContent, and PharmacyPictogram components from Core.
}
}

.searchContainer {
display: flex;
align-items: center;
flex-direction: row-reverse;
padding: 0.5rem 1rem 0;
padding: 0 spacing.$spacing-05 0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the top padding

}

:global(.cds--tab--list) button {
max-width: 12rem !important;
&[aria-selected='true'] {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the same thing as :global(.cds--tabs__nav-item--selected) {, just more concisely.

@denniskigen denniskigen marked this pull request as draft December 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant