Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) O3-4230: Bump @carbon/react to v1.71.0 #127

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

elishabantana
Copy link

@elishabantana elishabantana commented Nov 29, 2024

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR updates @carbon/react to v1.71.0, the latest release. It also:

  • Switches import paths to consolidated packages for color, type and spacing tokens from Carbon. This approach seems more future-proof and encourages consistency across the codebase.
  • Replaces hardcoded CSS spacing values with their Carbon equivalents.
  • Switches from the @import directive to @use for importing variables to enhance encapsulation and avoid naming conflicts:
    • @import adds everything to the global scope, while @use keeps imports modular by default, preventing naming conflicts.
    • @use includes the file only once, even if used multiple times, improving performance.
    • @use aligns with modern Sass best practices and is more future-proof.
  • Removes an unnecessary root.scss file.
  • Removes deprecated props for Carbon components (such as the light prop for ComboBox, Dropdown and Tile components, replacing them with the Layer wrapper instead).
  • Removes unused styles.

Screenshots

https://www.loom.com/share/edf94a4b5fa548eb835bfc9411a1eaa6?sid=075e13c9-32f0-4ba8-90a7-08266dd7a110

Related Issue

https://openmrs.atlassian.net/browse/O3-4230

Other

@denniskigen denniskigen changed the title (chore)Bump carbon version in dispensing (chore) Bump @carbon/react to v1.71.0 Dec 2, 2024
Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine. Would you be able to put together a video showing that everything still looks like it should?

@elishabantana
Copy link
Author

elishabantana commented Dec 3, 2024 via email


// TO DO Move this styles to style - guide
// https://github.com/openmrs/openmrs-esm-core/blob/master/packages/framework/esm-styleguide/src/_vars.scss
$color-blue-30: #a6c8ff;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing because this line of code was removed

@NethmiRodrigo NethmiRodrigo changed the title (chore) Bump @carbon/react to v1.71.0 (chore) O3-4230: Bump @carbon/react to v1.71.0 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants