-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) O3-4230: Bump @carbon/react to v1.71.0 #127
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems fine. Would you be able to put together a video showing that everything still looks like it should?
Let me do that
…On Mon, Dec 2, 2024, 23:13 Ian ***@***.***> wrote:
***@***.**** commented on this pull request.
Code seems fine. Would you be able to put together a video showing that
everything still looks like it should?
—
Reply to this email directly, view it on GitHub
<#127 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIRFYDTLH3UQSRVM2UY32F32DS5NVAVCNFSM6AAAAABSWXAKX2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZTHAYTGNJTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
||
// TO DO Move this styles to style - guide | ||
// https://github.com/openmrs/openmrs-esm-core/blob/master/packages/framework/esm-styleguide/src/_vars.scss | ||
$color-blue-30: #a6c8ff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build is failing because this line of code was removed
Requirements
Summary
This PR updates
@carbon/react
to v1.71.0, the latest release. It also:@import
directive to@use
for importing variables to enhance encapsulation and avoid naming conflicts:@import
adds everything to the global scope, while@use
keeps imports modular by default, preventing naming conflicts.@use
includes the file only once, even if used multiple times, improving performance.@use
aligns with modern Sass best practices and is more future-proof.root.scss
file.light
prop forComboBox
,Dropdown
andTile
components, replacing them with theLayer
wrapper instead).Screenshots
https://www.loom.com/share/edf94a4b5fa548eb835bfc9411a1eaa6?sid=075e13c9-32f0-4ba8-90a7-08266dd7a110
Related Issue
https://openmrs.atlassian.net/browse/O3-4230
Other