-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRUNK-4455: All metadata names should be case-insensitive. #4579
base: master
Are you sure you want to change the base?
Conversation
@djazayeri @dkayiwa @ibacher could you please review this PR |
@@ -1017,7 +1017,7 @@ public ConceptSource purgeConceptSource(ConceptSource cs) throws APIException { | |||
@Override | |||
public ConceptSource retireConceptSource(ConceptSource cs, String reason) throws APIException { | |||
// retireReason is automatically set in BaseRetireHandler | |||
return Context.getConceptService().saveConceptSource(cs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you change this accidentally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's part of the ConceptSource validation changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After changes in the ConceptSourceValidator
using the Context.getConceptService()
to access the saveConceptSource()
while retiring the ConceptSource
throws a hibernate exception. I think it's because the ConceptSource object trying to save is already retired by the BaseRetireHandler
and can't be accessed.
4a2cb44
to
b95d599
Compare
3c60987
to
af6d0c1
Compare
af6d0c1
to
9f8851c
Compare
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-4455
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amend
I ran
mvn clean package
right before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master