TRUNK-6190 Add fulfiller location in orders #4382
Conversation
|
@slubwama this being a new feature which we do not usually back port to previous versions, what is your plan for using it? Are you planning to upgrade your sites to the next platform release in order to take advantage of this? |
@dkayiwa that depends on how fast the 2.7.x series gets released. The reason why I had thought of backporting was to reduce the turnaround time. |
|
What plan do you have if 2.7 does not get released as fast as you will need? |
Backport was the plan. But since its not advised we may have to wait it out. |
|
Let us use order attributes, for now. |
@dkayiwa This is noted and followed up with the ticket and PR to ensure OrderAttributes do have REST Support before we can create fhir apis |
|
@slubwama are you still working on this? Or do you still need this guy? |
|
Yes. This work we had just paused it but we have an active sprint next
week we're this come back to the top.
…On Wed, 6 Dec 2023, 00:34 dkayiwa, ***@***.***> wrote:
@slubwama <https://github.com/slubwama> are you still working on this? Or
do you still need this guy?
—
Reply to this email directly, view it on GitHub
<#4382 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZOUKMGSUNHJK6OHFOM7TLYH6HO7AVCNFSM6AAAAAA4LHRCQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRGY2TANRXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed. OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) |
|
tl;dr closing this PR since it has not seen any activity in the last 6 months. OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner. Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :) |
Description of what I changed
In the Order Object I have added a field fulfillerLocation. This has also lead to changes in tests are assoriated. The affacted test classes are DrugOrderTest.java, OrderTest.java, ReferralOrderTest.java, TestOrderTest.java in test cloneForRevision_shouldSetAllTheRelevantFields
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-6190
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> Write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> Execute the above command
All new and existing tests passed.
No? Could you figure out why and add the fix to your commit? It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command `git pull --rebase upstream master