add convert oml dataset to mlr3 #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests/testthat/test_local_convertOMLSplitsToMlr3.R:12:40: style: Only use double-quotes. task$input$estimation.procedure[['type']]= oml.types[i]
^~~~~~tests/testthat/test_local_convertOMLSplitsToMlr3.R:12:48: style: Put spaces around all infix operators (except exponentiation). task$input$estimation.procedure[['type']]= oml.types[i]
~^ |
mb706
reviewed
Oct 15, 2019
| assertClass(obj, "OMLDataSet") | ||
| assertSubset(target, obj$colnames.new) | ||
| assertFlag(ignore.flagged.attributes) | ||
| assertFlag(drop.levels) |
There was a problem hiding this comment.
some assertions missing (mlr.task.id, fix.colnames, verbosity)
| return(mlr.task) | ||
| } | ||
|
|
||
| replaceOMLDataSetString = function(string, data.set) { |
There was a problem hiding this comment.
this function already exists in convertOMLDataSetToMlr.R. unless we plan to remove mlr support this should not be duplicated. Same with guessTaskType and possibly others.
mllg
approved these changes
Oct 15, 2019
| n.repeats = estim.proc$parameters[["number_repeats"]] | ||
| n.folds = estim.proc$parameters[["number_folds"]] | ||
| percentage = as.numeric(estim.proc$parameters[["percentage"]]) | ||
| data.splits = estim.proc$data.splits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.