Update mlnet #522
Open
Update mlnet #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PGijsbers Hi can you check why ci/cd build is cancelled all the time? |
|
Not entirely sure. I just merged #520, maybe you can rebase your PR on top of the updated |
added 2 commits
August 20, 2023 20:14
|
@PGijsbers I finally got some time to fix this PR. Could you review it. |
PGijsbers
requested changes
Aug 24, 2023
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
| HERE=$(dirname "$0") | |||
| MLNET='mlnet' | |||
| MLNET_PACKAGE='mlnet-linux-x64' | |||
There was a problem hiding this comment.
Would it be possible to adjust this so it also works on ARM (and preferably also macos)? For example by storing the result of:
import sys
import platform
platform = {"linux": "linux", "darwin": "osx"}.get(sys.platform)
machine = {"arm64": "arm64", "x86_64": "x64"}.get(platform.machine())
print(f"mlnet-{platform}-{machine}")There was a problem hiding this comment.
yep that would work. You might need to target to different platform for arm64 and x64 though
available packages
- mlnet-linux-x64
- mlnet-linux-arm64
- mlnet-macos-x64
- mlnet-macos-arm64 (for m-seriese chip)
There was a problem hiding this comment.
That should be in the above script already :) and based on the installation docs the mac abbreviation is osx instead of macos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.