Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements to the WMC tool #174

Open
wants to merge 69 commits into
base: dev
Choose a base branch
from
Open

Conversation

malenov
Copy link
Contributor

@malenov malenov commented Nov 2, 2023

This is an update of the WMC tool addressing issues listed in #172.

@malenov
Copy link
Contributor Author

malenov commented Feb 26, 2024

adding @maadolph and @ludomal

@ludomal
Copy link
Member

ludomal commented Feb 26, 2024

Thanks @malenov for the update. Shall we consider the code as stable and ready for review?

Do we need to update the manual? I've seen that usage for wmc_tool.c has been updated, so I expect wmc_tool.tex to be updated to reflect the changes?

@malenov
Copy link
Contributor Author

malenov commented Feb 26, 2024

@ludomal, thanks for noticing this. You're right. I've updated the manual by adding some information describing the the newly supported command-line argument.

Copy link
Member

@ludomal ludomal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for inclusion to the proposal for the next release of STL.
The update compiles and passes test vectors.

@malenov
Copy link
Contributor Author

malenov commented Jul 22, 2024

Dear @ludomal, I've made a small modification in the CMakeLists.txt that I'd like you to review. The find_package(PythonInterp) module has been deprecated since CMake version 3.12 and has been replaced with the findPython() module. I'm okay with continuing to use the old module if you believe it's better for portability. However, in that case, I recommend setting the CMP0148 policy appropriately.

malenov added 21 commits July 22, 2024 13:31
…on plus some instrumented code, e.g. encoder.c
…e but before the last automatically instrumented segment
…et_indices(), write_indices(), read_indices(), read_bitstream_info(), reset_stack() and push_stack() from the list of reserved function names
…unction

- update of memory consumption counters is part of update_wmops()
- replace the code updating the worst-case intra-frame and inter-frame heap memory consumption
- support for per-frame and per-block memory consumption exported to a .csv file
- fix incorrect calculation of the worst-case heap size for memory blocks allocated and de-allocated multiple times in a single frame
…sed on the .csv memory output file generated by the WMC tool
…placing constants MAX_RECORDS and MAX_RECORDABLE_CALLS), allows for re-allocation if max size is exceeded
malenov and others added 30 commits July 29, 2024 15:54
add explanation about where to place the push_wmops() function calls
… skipping complexity instrumentation in function bodies
…on plus some instrumented code, e.g. encoder.c
…e but before the last automatically instrumented segment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants