CM-932: added make payment button for digital strategy #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lruzicki
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Great that you stick to the best practices but I have left one comment, take a look in the code. Also consider adding description to PR to make it more readable. While this one is self explanatory from title it may be a good idea to add always include:
- ticket
- description (for those who dont have access to Jira)
- how was it tested
src/components/payroll/dialogs/PaymentApproveForPaymentSummary.js
Outdated
Show resolved
Hide resolved
|
lruzicki
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: https://openimis.atlassian.net/browse/CM-932
PR to add 'Make Payment' button when payroll is accepted for 'APPROVE_FOR_PAYMENT' for 'OnlineStrategyPayment' only.