Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-1725: remove null/empty option from dropdowns #67

Merged
merged 1 commit into from
Jan 15, 2024
Merged

OP-1725: remove null/empty option from dropdowns #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/ContractHeadPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,7 @@ class ContractHeadPanel extends FormPanel {
<PublishedComponent
pubRef="policyHolder.PolicyHolderPicker"
module="contract"
withNull
nullLabel={formatMessage(intl, "contract", "emptyLabel")}
withNull={false}
value={!!edited && !!edited.policyHolder && edited.policyHolder}
onChange={(v) => this.updateAttribute("policyHolder", v)}
readOnly={
Expand Down
4 changes: 2 additions & 2 deletions src/dialogs/CreateContractDetailsDialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class CreateContractDetailsDialog extends Component {
<PublishedComponent
pubRef="policyHolder.PolicyHolderInsureePicker"
required
withNull
withNull={false}
policyHolderId={contract?.policyHolder?.id}
value={!!contractDetails.insuree && contractDetails.insuree}
onChange={v => this.updateAttribute('insuree', v)}
Expand All @@ -148,7 +148,7 @@ class CreateContractDetailsDialog extends Component {
<Grid item className={classes.item}>
<PublishedComponent
pubRef="policyHolder.PolicyHolderContributionPlanBundlePicker"
withNull
withNull={false}
nullLabel={formatMessage(intl, "contract", "emptyLabel")}
policyHolderId={contract?.policyHolder?.id}
value={!!contractDetails.contributionPlanBundle && contractDetails.contributionPlanBundle}
Expand Down
4 changes: 2 additions & 2 deletions src/dialogs/UpdateContractDetailsDialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class CreateContractDetailsDialog extends Component {
<PublishedComponent
pubRef="policyHolder.PolicyHolderInsureePicker"
required
withNull
withNull={false}
policyHolderId={contract?.policyHolder?.id}
value={!!contractDetails.insuree && contractDetails.insuree}
readOnly
Expand All @@ -158,7 +158,7 @@ class CreateContractDetailsDialog extends Component {
<Grid item className={classes.item}>
<PublishedComponent
pubRef="policyHolder.PolicyHolderContributionPlanBundlePicker"
withNull
withNull={false}
nullLabel={formatMessage(intl, "contract", "emptyLabel")}
policyHolderId={contract?.policyHolder?.id}
value={!!contractDetails.contributionPlanBundle && contractDetails.contributionPlanBundle}
Expand Down