Legrand with Netatmo cluster 0xfc01 support #736
Conversation
| * @param s String that shall be unescaped. | ||
| * @return UTF16 string | ||
| */ | ||
| private static final String unescape(String s) { |
There was a problem hiding this comment.
Why does this need to be static? I can't immediately see a need for that so if it's not required then I'd suggest to remove this.
There was a problem hiding this comment.
unescape is rather a utility method than a member of TigBeeThingTypeMatcher, as it does not apply to its properties but to a String argument. In this kind of case, I usually create a Util class for holding such methods as static ones. Here, with only one util method, keeping it in the user class looked to be the best choice.
There was a problem hiding this comment.
Ok, but I see it as just another method in the class and I think in general making all (or really, any) methods static is not highly desirable. If this was a helper class where you were providing static methods externally, then I could see some merit, but as it is it's all internal and private.
I'm happy for it to be in the user class - it certainly makes no sense for it to be elsewhere - I just don't see the need to make it static.
There was a problem hiding this comment.
Fixed. Removed "final" too after having thought about it.
| @@ -172,4 +172,30 @@ public RequiredProperty(String name, String value) { | |||
| this.value = value; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
It looks like this needs formatting as this method doesn't line up with the method above. It looks like tabs have been used rather than spaces?
There was a problem hiding this comment.
I accidentally applied spotless settings to all the code and had to cancel it later. This is probably a resulting error. I am going to fix it.
There was a problem hiding this comment.
I applied openhab formatter style to this method. It should be ok now. Same thing for the import order.
Handles invisible/special characters with \u<xxxx> Unicode escape notation. Signed-off-by: Pierre Gaufillet <[email protected]>
|
Thanks for this @pgaufillet - looks good now. |
Implement Legrand with Netatmo cluster 0xfc01 support as described in issue #733.
Signed-off-by: Pierre Gaufillet [email protected]