Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default element type to sitemap documentation #159

Merged
merged 1 commit into from
Jan 15, 2017
Merged

Add Default element type to sitemap documentation #159

merged 1 commit into from
Jan 15, 2017

Conversation

pfink
Copy link
Contributor

@pfink pfink commented Dec 17, 2016

see eclipse-archived/smarthome#1535

Signed-off-by: Patrick Fink [email protected]

@ThomDietrich
Copy link
Member

Hey Patrick!
Thanks for your contribution! Adding default was one of the open tasks discussed in #53. Would you like to tackle the other once as well? If not, just let me know and we can go on with the current PR content ;)

@pfink
Copy link
Contributor Author

pfink commented Dec 20, 2016

Hi Thomas!

Unfortunately, I don't know the other ones. I always work this way: I'm figuring out the things I currently need (which is mostly of course just a small subset from what is available), and if parts of it were not documented, I directly open PRs with the content I just figured out to prevent that others run into the same issue. In my opinion that's a good compromise between being an overall maintainer which is quite time consuming or, the other extreme, not contributing anything at all.

So you'll may see more Mini-PRs by me in the future that'll improve stuff bit by bit :-)

@ThomDietrich ThomDietrich merged commit 52d7927 into openhab:gh-pages Jan 15, 2017
@ThomDietrich
Copy link
Member

Thanks @pfink for both your PRs!

DocFraggle pushed a commit to DocFraggle/openhab-docs that referenced this pull request Jan 16, 2017
@Confectrician Confectrician added this to the 2.0 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants