-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle UnitUtils.getDimensionName for mirek #4507
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b29673b
special case UnitUtils.getDimensionName for mirek
ccutrer 0a70b77
check if the inverse unit is compatible, instead of special case
ccutrer fcc4b3f
address review comments
ccutrer ea48fdf
switch to two loops, ensuring a directly compatible dimension is foun…
ccutrer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,8 @@ | |
import javax.measure.Unit; | ||
import javax.measure.quantity.Angle; | ||
import javax.measure.quantity.Dimensionless; | ||
import javax.measure.quantity.ElectricConductance; | ||
import javax.measure.quantity.ElectricResistance; | ||
import javax.measure.quantity.Energy; | ||
import javax.measure.quantity.Length; | ||
import javax.measure.quantity.Power; | ||
|
@@ -120,6 +122,12 @@ public void testGetDimensionNameWithDimension() { | |
|
||
unit = Objects.requireNonNull(UnitUtils.parseUnit("m")); | ||
assertThat(UnitUtils.getDimensionName(unit), is(Length.class.getSimpleName())); | ||
assertThat(UnitUtils.getDimensionName(Units.MIRED), is(Temperature.class.getSimpleName())); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps add the following line to assert that nothing got broken due to the new inversion test..
|
||
assertThat(UnitUtils.getDimensionName(Units.KELVIN), is(Temperature.class.getSimpleName())); | ||
assertThat(UnitUtils.getDimensionName(SIUnits.CELSIUS), is(Temperature.class.getSimpleName())); | ||
assertThat(UnitUtils.getDimensionName(ImperialUnits.FAHRENHEIT), is(Temperature.class.getSimpleName())); | ||
assertThat(UnitUtils.getDimensionName(Units.SIEMENS), is(ElectricConductance.class.getSimpleName())); | ||
assertThat(UnitUtils.getDimensionName(Units.OHM), is(ElectricResistance.class.getSimpleName())); | ||
} | ||
|
||
@Test | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does unit.inverse() always return a non null value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It may not make immediate logical sense (what's Meter^-1?), but it always has a value.