[lutron] Add setLevel thing action to dimmer #8153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Adair <[email protected]>
Signed-off-by: Bob Adair <[email protected]>
* Fix NPE when setting fadeInTime and fadeOutTime variables prior to handler initialization Signed-off-by: Austin Guiswite <[email protected]> (cherry picked from commit f2533fe)
Signed-off-by: Bob Adair <[email protected]>
bobadair
added
the
enhancement
|
This PR already contains the workaround for issue openhab/openhab-core#1265 suggested in #8116. |
|
Thanks @Hilbrand, and thanks @aguiswite! |
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
* [lutron] Workaround for thing actions bug * [lutron] Fix NPE * Fix NPE when setting fadeInTime and fadeOutTime variables prior to handler initialization Also-by: Austin Guiswite <[email protected]> Signed-off-by: Bob Adair <[email protected]> Signed-off-by: MPH80 <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [lutron] Workaround for thing actions bug * [lutron] Fix NPE * Fix NPE when setting fadeInTime and fadeOutTime variables prior to handler initialization Also-by: Austin Guiswite <[email protected]> Signed-off-by: Bob Adair <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [lutron] Workaround for thing actions bug * [lutron] Fix NPE * Fix NPE when setting fadeInTime and fadeOutTime variables prior to handler initialization Also-by: Austin Guiswite <[email protected]> Signed-off-by: Bob Adair <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [lutron] Workaround for thing actions bug * [lutron] Fix NPE * Fix NPE when setting fadeInTime and fadeOutTime variables prior to handler initialization Also-by: Austin Guiswite <[email protected]> Signed-off-by: Bob Adair <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [lutron] Workaround for thing actions bug * [lutron] Fix NPE * Fix NPE when setting fadeInTime and fadeOutTime variables prior to handler initialization Also-by: Austin Guiswite <[email protected]> Signed-off-by: Bob Adair <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* [lutron] Workaround for thing actions bug * [lutron] Fix NPE * Fix NPE when setting fadeInTime and fadeOutTime variables prior to handler initialization Also-by: Austin Guiswite <[email protected]> Signed-off-by: Bob Adair <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
* [lutron] Workaround for thing actions bug * [lutron] Fix NPE * Fix NPE when setting fadeInTime and fadeOutTime variables prior to handler initialization Also-by: Austin Guiswite <[email protected]> Signed-off-by: Bob Adair <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* [lutron] Workaround for thing actions bug * [lutron] Fix NPE * Fix NPE when setting fadeInTime and fadeOutTime variables prior to handler initialization Also-by: Austin Guiswite <[email protected]> Signed-off-by: Bob Adair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a setLevel(level, fadeTime, delayTime) thing action to the dimmer thing. This allows a level command to be sent with associated fade and delay times.
As discussed previously in openhab/openhab-core#1298, I think it is unfortunate that there isn't a more standard way to add this functionality. Even some attempt at defining a standard set of thing actions might be useful here, so that common actions across different things could be somewhat consistent. In the absence of that, I just picked an action name that I thought logical.
This update also includes a new LutronDuration class for time durations, which will eventually be useful for other coming improvements to the binding.
Signed-off-by: Bob Adair [email protected]
Also-by: Austin Guiswite