[pushbullet] Replace deprecated URL constructor #17982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
reviewed
Dec 28, 2024
...hbullet/src/main/java/org/openhab/binding/pushbullet/internal/handler/PushbulletHandler.java
Outdated
Show resolved
Hide resolved
jsetton
force-pushed
the
pushbullet-handler-refactor
branch
from
b815d1a to
6d8b9f6
Compare
jsetton
changed the title
jsetton
force-pushed
the
pushbullet-handler-refactor
branch
from
6d8b9f6 to
fb26bf6
Compare
|
DCO passed? |
Yes, it did. But in addition to the DCO we also have a real name requirement (see the provided link). I tried to find it in previous commits, but it appears this has been missing (and gone unnoticed) since your very first commit. If we just had one commit "in our records" with real name, we could omit it here, since we'd be able to cross-reference. But since it doesn't appear so, I'd rather have this fixed before merging this PR. Sorry for being picky here and quite late to spot it. 🙂 |
Signed-off-by: Jeremy Setton <[email protected]>
jsetton
force-pushed
the
pushbullet-handler-refactor
branch
from
fb26bf6 to
4148246
Compare
Done. |
Excellent, thanks! |
DrRSatzteil
pushed a commit
to DrRSatzteil/openhab-addons
that referenced
this pull request
Jan 3, 2025
Signed-off-by: Jeremy Setton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced deprecated
URLconstructor withURIone.