[tellstick] Add null annotations #17974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lsiepel
commented
Dec 24, 2024
lsiepel
commented
- Add null annotations
- Fixed most warnings as a result of adding null annotations.
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
jlaur
requested changes
Dec 28, 2024
| public String ipAddress; | ||
| public String accessToken; | ||
| public String ipAddress = ""; | ||
| public String accessToken = ""; | ||
| public long refreshInterval; |
There was a problem hiding this comment.
Perhaps the default:
should be added here as well?
Suggested change
| public long refreshInterval; | |
| public long refreshInterval = 60000; |
...tick/src/main/java/org/openhab/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java
Outdated
Show resolved
Hide resolved
...tick/src/main/java/org/openhab/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java
Outdated
Show resolved
Hide resolved
| if (strValue != null) { | ||
| value = Double.valueOf(strValue); | ||
| if (dev instanceof TellstickDevice device) { | ||
| String strValue = null; |
There was a problem hiding this comment.
Is this assignment necessary?
There was a problem hiding this comment.
Otherwise I get a warning the var is not initialised
There was a problem hiding this comment.
Okay. Maybe a slight refactor will make it more readable?
String strValue = device.getData();
if (strValue != null) {
value = Double.valueOf(strValue);
}There was a problem hiding this comment.
Way better. Wondering why i took that turn... :-)
| logger.debug("Current remaining delay {}", pollingJob.getDelay(TimeUnit.SECONDS)); | ||
| if (pollingJob.getDelay(TimeUnit.SECONDS) > REFRESH_DELAY) { | ||
| ScheduledFuture<?> immediateRefreshJob = this.immediateRefreshJob; | ||
| if (immediateRefreshJob == null || immediateRefreshJob.isDone()) { | ||
| immediateRefreshJob = scheduler.schedule(this::refreshDeviceList, REFRESH_DELAY, TimeUnit.SECONDS); |
There was a problem hiding this comment.
This will start a wild-running thread.
There was a problem hiding this comment.
Should be fixed now.
...k/src/main/java/org/openhab/binding/tellstick/internal/live/TelldusLiveDeviceController.java
Outdated
Show resolved
Hide resolved
…b/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: lsiepel <[email protected]>
…b/binding/tellstick/internal/core/TelldusCoreBridgeHandler.java Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: lsiepel <[email protected]>
…b/binding/tellstick/internal/live/TelldusLiveDeviceController.java Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: lsiepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.