Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amazonechocontrol] Add do not disturb channel #17935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Dec 20, 2024

This is a port of smarthomej/addons#391 that I've been using for years, but I hear the main distro version of the binding should be functional again, and I'd rather not have to wait for it to become compatible after a new core release each time again.

@ccutrer ccutrer requested a review from mgeramb as a code owner December 20, 2024 15:33
@J-N-K
Copy link
Member

J-N-K commented Dec 20, 2024

I would prefer if you backport all changes. I just don't have time for that at the Moment. I can help if Problems occur.

@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 20, 2024

Sure, I can help you with that. I still need to test my other use cases besides DnD. I'll work on the rest of them over the next two weeks. Do you prefer if I stuff it all into a single PR, or do PR per "topic" that happened in smarthomej?

Tangentially- what are your plans for the Tuya binding? I'd be happy to work on porting that into the main distro as well.

@J-N-K
Copy link
Member

J-N-K commented Dec 20, 2024

@ccutrer I think that it would be better to do single PR because some of the PR had issues that were later fixed together in another PR. What I did when backporting other changes is to just replace the openhab version with the smarthomej version, rename the directory, do a search&replace for org.smarthomej and then check fi something unwanted was reverted.

@J-N-K
Copy link
Member

J-N-K commented Dec 20, 2024

Regarding Tuya: fine with me.

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants