[tapocontrol] Add Smart Switches S210 and S220 #17927
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mkmannmanny <[email protected]>
Signed-off-by: mkmannmanny <[email protected]>
Signed-off-by: mkmannmanny <[email protected]>
Signed-off-by: mkmannmanny <[email protected]>
jlaur
changed the title
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
mkmannmanny
requested review from
mlobstein,
cweitkamp,
EvilPingu,
wborn,
bern77,
seime,
marcelrv,
weymann,
jannegpriv,
sgiehl,
bobadair,
syphr42,
Markinus,
jsjames,
paulianttila,
digitaldan,
J-N-K,
Andy2003,
kgoderis,
florian-h05,
maniac103,
limdul79,
DerOetzi,
rmichalak,
soenkekueper,
david-pace,
GerdZanker and
jofleck
as code owners
|
@mkmannmanny you need to rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Tapo Smart Switches S210 and S220 to the tapocontrol binding. The devices are quite usefull as they can be used to replace your existing wall switches to switch your lights with openhab.
The .jar executable to test upfront is located here .
For developers:
I'm new as a developer in Openhab. I used this binding to get used to the binding architecture and the coding sytle. Thank's to Christian, the code is well structured and easy to understand. I had a lot more trouble to setup the infrastructure (openhab-distro, Eclipse, Github) then to undstand your source code.
Some words to my modifications/additions. I added a new Class TapoSmartSwitchHandler that extends TapoChildDeviceHandler. Besides adding the two devices to constants and xml the main modifications in existing classes are to send the OnOff command from the Child via the hub to the protokol part.
It would be good, somebody with a litle bit more expierience than me could take a close look on the changes.