-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[velbus] New functionality & Bug fix #17926
Open
Rosen01
wants to merge
73
commits into
openhab:main
Choose a base branch
from
Rosen01:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New functionnality : - Add output channel for modules : VMBEL1, VMBEL2, VMBEL4, VMBELO, VMBELPIR. (openhab#14179) - Add module VMBDALI. (openhab#14654) Fix bug : - No access to sub-address modules when adding manually the modules : VMBELO,VMBGPO, VMBGPOD, VMBGPOD-2 (openhab#12702) - Thermostat event wrongly fired when using push button on sub-address for modules VMBELO, VMBGPO, VMBGPOD, VMBGPOD_2. - Wrong typeId for bridge alarms management. Signed-off-by: Daniel Rosengarten <[email protected]>
Changed the management of VMBDALI white channel. Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusBindingConstants.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusBindingConstants.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/discovery/VelbusThingDiscoveryService.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java Co-authored-by: Simonas Kazlauskas <[email protected]> Signed-off-by: Daniel Rosengarten <[email protected]>
* VelbusVirtualColorChannel class Permits different values (CH0 or A0) to configure the virtual light's channels. * VelbusColorChannel class Makes color transformation easy with the rescale function. * onPacketReceived interface Stops processing packets when handler is disposed. Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Thing upgrade instructions for VMBEL1, VMBEL2, VMBEL4, VMBELO. Signed-off-by: Daniel Rosengarten <[email protected]>
Update Readme. Signed-off-by: Daniel Rosengarten <[email protected]>
Add modules : VMB4RYLD-10, VMB4RYNO-10, VMB2BLE-10, VMB6PB-20, VMBEL1-20, VMBEL2-20, VMBEL4-20, VMBELO-20, VMBGP1-20, VMBGP2-20, VMBGP4-20, VMBGPO-20, VMBDALI-20, VMBEL4PIR-20, VMBGP4PIR-20 Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Added missing bundle reference in channel type. Signed-off-by: Daniel Rosengarten <[email protected]>
Modules : VMB4LEDPWM-20, VMB8DC-20 Signed-off-by: Daniel Rosengarten <[email protected]>
New functionality : - Add modules : VMBPIRO-10, VMBPIR-20, VMB8IN-20 Fix bug : - Correct typo in thing type for module VMB6PB-20. - Remove properties 'Refresh Interval' from modules VMBPIRC, VMBPIRM. - Add CH8 properties to VMB7IN. - Add fade-mode channel on VMB4LEDPWM-20 and VMB8DC-20 modules. - Update readme. Signed-off-by: Daniel Rosengarten <[email protected]>
- Code cleanup - Fix VMB7IN config description - Fix initialization error for modules VMB8DC-20 and VMB4LEDPWM-20 Signed-off-by: Daniel Rosengarten <[email protected]>
Fix bug : - Channels name retrieved from modules not set correctly to the right channel - Remove sub-address property for modules VMBPIRO and VMBPIRO-10 Signed-off-by: Daniel Rosengarten <[email protected]>
Remove unneeded channels on modules VMB4PWMLED-20 and VMB8DC-20. Signed-off-by: Daniel Rosengarten <[email protected]>
- Remove ClockAlarm channel group on modules VMB4LEDPWM-20 and VMB8DC-20 - Use exponential curve values for brightness on modules VMBDALI, VMBDALI-20, VMB4LEDPWM-20, VMB8DC-20 Signed-off-by: Daniel Rosengarten <[email protected]>
Fix bug : - VMB8DC-20 uses a linear system for the dimming. - VMB4LEDPWM-20, VMBDALI, VMBDALI-20 uses an exponential curve system for the dimming. Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Update readme. Signed-off-by: Daniel Rosengarten <[email protected]>
Thanks for this PR! Before i review i like to ask you if it would be possible to split this PR in 2 (or more) seperate PR's. One that fixes bugs and one that adds features (channels). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New functionality :
Fix bug :
Link for testing : Releases
Signed-off-by: Daniel Rosengarten [email protected]