Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velbus] New functionality & Bug fix #17926

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

[velbus] New functionality & Bug fix #17926

wants to merge 73 commits into from

Conversation

Rosen01
Copy link
Contributor

@Rosen01 Rosen01 commented Dec 18, 2024

New functionality :

  • Add modules : VMB4LEDPWM-20, VMB8DC-20, VMBPIRO-10, VMBPIR-20, VMB8IN-20

Fix bug :

  • Correct typo in thing type for module VMB6PB-20.
  • Remove properties 'Refresh Interval' from modules VMBPIRC, VMBPIRM.
  • Add CH8 properties on VMB7IN module.
  • Channels name retrieved from modules not set correctly to the right channel.
  • Remove property 'Refresh Interval' from modules VMBPIRC, VMBPIRM.
  • Remove sub-address property for modules VMBPIRO.
  • VMBDALI, VMBDALI-20 use an exponential curve system for the dimming.
  • Update readme.

Link for testing : Releases

Signed-off-by: Daniel Rosengarten [email protected]

Rosen01 and others added 30 commits September 27, 2023 23:39
New functionnality :
- Add output channel for modules : VMBEL1, VMBEL2, VMBEL4, VMBELO, VMBELPIR. (openhab#14179)
- Add module VMBDALI. (openhab#14654)

Fix bug :
- No access to sub-address modules when adding manually the modules : VMBELO,VMBGPO, VMBGPOD, VMBGPOD-2 (openhab#12702)
- Thermostat event wrongly fired when using push button on sub-address for modules VMBELO, VMBGPO, VMBGPOD, VMBGPOD_2.
- Wrong typeId for bridge alarms management.

Signed-off-by: Daniel Rosengarten <[email protected]>
Changed the management of VMBDALI white channel.

Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusBindingConstants.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusBindingConstants.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/discovery/VelbusThingDiscoveryService.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
…inding/velbus/internal/VelbusVirtualColorChannel.java

Co-authored-by: Simonas Kazlauskas <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
* VelbusVirtualColorChannel class
Permits different values (CH0 or A0) to configure the virtual light's channels.
* VelbusColorChannel class
Makes color transformation easy with the rescale function.
* onPacketReceived interface
Stops processing packets when handler is disposed.

Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Thing upgrade instructions for VMBEL1, VMBEL2, VMBEL4, VMBELO.

Signed-off-by: Daniel Rosengarten <[email protected]>
Update Readme.

Signed-off-by: Daniel Rosengarten <[email protected]>
Add modules : VMB4RYLD-10, VMB4RYNO-10, VMB2BLE-10, VMB6PB-20, VMBEL1-20, VMBEL2-20, VMBEL4-20, VMBELO-20, VMBGP1-20, VMBGP2-20, VMBGP4-20, VMBGPO-20, VMBDALI-20, VMBEL4PIR-20, VMBGP4PIR-20

Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Added missing bundle reference in channel type.

Signed-off-by: Daniel Rosengarten <[email protected]>
Rosen01 and others added 28 commits May 11, 2024 23:15
Modules : VMB4LEDPWM-20, VMB8DC-20

Signed-off-by: Daniel Rosengarten <[email protected]>
New functionality :
- Add modules : VMBPIRO-10, VMBPIR-20, VMB8IN-20

Fix bug :
- Correct typo in thing type for module VMB6PB-20.
- Remove properties 'Refresh Interval' from modules VMBPIRC, VMBPIRM.
- Add CH8 properties to VMB7IN.
- Add fade-mode channel on VMB4LEDPWM-20 and VMB8DC-20 modules.
- Update readme.

Signed-off-by: Daniel Rosengarten <[email protected]>
- Code cleanup
- Fix VMB7IN config description
- Fix initialization error for modules VMB8DC-20 and VMB4LEDPWM-20

Signed-off-by: Daniel Rosengarten <[email protected]>
Fix bug :
- Channels name retrieved from modules not set correctly to the right channel
- Remove sub-address property for modules VMBPIRO and VMBPIRO-10

Signed-off-by: Daniel Rosengarten <[email protected]>
Remove unneeded channels on modules VMB4PWMLED-20 and VMB8DC-20.

Signed-off-by: Daniel Rosengarten <[email protected]>
- Remove ClockAlarm channel group on modules VMB4LEDPWM-20 and VMB8DC-20
- Use exponential curve values for brightness on modules VMBDALI, VMBDALI-20, VMB4LEDPWM-20, VMB8DC-20

Signed-off-by: Daniel Rosengarten <[email protected]>
Fix bug :
- VMB8DC-20 uses a linear system for the dimming.
- VMB4LEDPWM-20, VMBDALI, VMBDALI-20 uses an exponential curve system for the dimming.

Signed-off-by: Daniel Rosengarten <[email protected]>
Signed-off-by: Daniel Rosengarten <[email protected]>
Update readme.

Signed-off-by: Daniel Rosengarten <[email protected]>
@Rosen01 Rosen01 requested a review from cedricboon as a code owner December 18, 2024 17:32
@lsiepel
Copy link
Contributor

lsiepel commented Dec 18, 2024

Thanks for this PR! Before i review i like to ask you if it would be possible to split this PR in 2 (or more) seperate PR's. One that fixes bugs and one that adds features (channels).
If not we have to deal with it ;-) but in general we prefer smaller PR's as they are easier to review, backport and show up independent in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants