[dirigera] Initial contribution

[weymann]

Binding for IKEA DIRIGERA hub for smart products.

The work ist still in progress but I would like to start the review to find breaking changes right now and not at the end, e.g. thing and channel names.

The binding is published on Marketplace and Community Discussion is active.

[lsiepel]

Only looked at the thing-structure.xml files as you wanted early feedback.

I did not repeat the same comments for multiple Things. As this seems a well strucutered binding, i think it would be easy for you to project my comments on the other Things.

Extra note, please user system state channels where possible:
https://www.openhab.org/docs/developer/bindings/thing-xml.html#system-state-channel-types

[lsiepel]

What is the difference between state and status in this case?
Applies to multiple Things

[weymann]

I also needed to Google this :)

otaStatus and otaState derived from working repository

[weymann]

@lsiepel
Thanks for the fast reply - I'll start now working on this.

[weymann]

@lsiepel
All channel adaptions done which shall be now in a stable status.
Binding is running for several community members who reported positive results for several devices. Stability improved with watchdog running.

I don't forsee changes in architecture, class structure and general behavior. Only in specific device handlers if bugfixes are necessary. So I would ask to extend the review on code. Leave logging out of scope, this is still messy and I'm still working on that.

[weymann]

@lsiepel @jlaur
What's wrong with the DateTimeType? Didn't changed anything but now it's throwing an error!

First log: String got from device json - ok
Second log: ZonedDateTime after conversion with defined TimeZone +02:00 - ok
Third log: Created DateTimeType

[main] WARN  o.o.b.d.i.handler.scene.SceneHandler - LastTrigger Instant       2024-10-16T00:21:15.977Z
[main] WARN  o.o.b.d.i.handler.scene.SceneHandler - LastTrigger ZonedDateTime 2024-10-16T02:21:15.977+02:00[Europe/Berlin]
[main] WARN  o.o.b.d.i.handler.scene.SceneHandler - LastTrigger DateTimeType  2024-10-16T00:21:15.977+0000
[main] WARN  o.o.b.d.internal.mock.CallbackMock - Update dirigera:scene:test-device:last-trigger : 2024-10-16T00:21:15.977+0000

Code here

[jlaur]

What's wrong with the DateTimeType?

Hopefully nothing is wrong - see #17719 (comment)

Didn't changed anything but now it's throwing an error!

I assume it's your test throwing an error? Otherwise please be more specific. See #17719 (comment) regarding the test.

[lsiepel]

So many files to look at, so have to break this up into smaller review rounds. This is a first pass. Besides the comments, want to point to recent changes:
color-temperate channels: #17754 for recent DatetimeType channels: #17725

Edit: lol. nice timing

[lsiepel]

You could provide the channels with option lists in the xml, this would prevent any mapping, make the UI able to provide presets and would make translation easier.

[weymann]

It's already in
For usage in UI these mappings are not needed.
For rules it's useful to have these mappings to check state updates and sending commands.

[lsiepel]

See earlier comment, better to have option lists.

[weymann]

Same comment

[lsiepel]

Think you accidently moved this file instead of copying. Needs to be fixed.

[weymann]

I've no idea what's going on here.
Removing exceptions temporary, thenBaseDeviceConfiguration is guilty of moving this file.

Created Excpetion classes from scratch, now ApiException is the one marked moving. I'm clueless.

Fact: There's no file moved from anywhere

[weymann]

So many files to look at, so have to break this up into smaller review rounds. This is a first pass. Besides the comments, want to point to recent changes: color-temperate channels: #17754 for recent DatetimeType channels: #17725

Edit: lol. nice timing

For color temperature #17754 since the beginning it was no option to set kelvin or system:color-temperature-abs directly - this should be fine!
For DateTimeType commit is already in place