[modbus.lambda] Lambda Heat Pump

[chilobo]

This is my first contribution on github!

Based on the Stiebel Eltron bundle by Paul Frank I contribute a bundle to manage Lambda Heat Pumps as a OSG addon to the Modbus Binding.

I did some testing by adding my jar to the local addon directory.
See the README.md for restrictions on usage.

The binding is based on the Modbus description of the manufacturer:
(https://lambda-wp.at/wp-content/uploads/2022/01/Modbus-Protokoll-und-Beschreibung.pdf)

Compressed directory:
org.openhab.binding.modbus.lambda.zip

[lsiepel]

Thank you for this contribution. It would be nice if you could perform a self review see the checklist here: https://github.com/openhab/openhab-addons/wiki/Review-Checklist
Also make sure that this binding is also added to files outside of the binding folder:
bom/openhab-addons/pom.xml
bundles/pom.xml
CODEOWNERS

Once these are done, me or another maintainer will review this. Just ping if you need anything.

[chilobo]

Once these are done, me or another maintainer will review this. Just ping if you need anything.

I added the changes to
bom/openhab-addons/pom.xml
bundles/pom.xml
CODEOWNERS
and put some // in front of my trace loggings.
I read the Review-Checklist.
I guess some of the channel names are too long, but

• I tried to stick with the names the manufacturer provided.
• Some descriptions of the modbus registers are quite similar in different groups, so shortening them could produce legibility problems.

After some fiddling with git to signoff my commits and annoying problems with VS formatting pom.xml etc. the project was compiled without errors in github.
Please review!

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/add-heatpump-binding-to-modbus-binding-help-needed/157725/10

[lsiepel]

Thank you for contributing to openHAB, greatly appreciated. This is a partly review, I looked at 33/38 files. I left some comments, the most important one is about getting the openHAB side of the moddeling right. From there on i can look at the rest of the files. Let me know if you need anything

[chilobo]

I am lost.
@Java17: The details button does not show what the problem is.
The problem with the DCO Action cannot be resolved by me because I am not a codeowner of openhab?

[lsiepel]

I am lost. @Java17: The details button does not show what the problem is. The problem with the DCO Action cannot be resolved by me because I am not a codeowner of openhab?

If you click details next to the DCO issue, there are 4 commits that lack the signoff. That page also lists some actions to take to fix it. (you have to rewrite the commit message).

[lsiepel]

Thank you for fixing most comments quicly. When looking at the other files i got some new ones. Only the handler is left to review. But that is only usefull after we finished the modelling of things and channels.

[chilobo]

I think I am finished with the necessary changes.
@ISiepel: Is there anything else missing?

[lsiepel]

Some commits got accidently added to this PR. Please rebase / undo excess commits

[chilobo]

@lsiepel
I did a rebase removed some tracelogs and would ask you to have a look at the project again.

[lsiepel]

@lsiepel I did a rebase removed some tracelogs and would ask you to have a look at the project again.

Could you fix the excess commits and conflicts? I guess something went wrong with rebasing.

[chilobo]

@lsiepel I did a rebase removed some tracelogs and would ask you to have a look at the project again.

Could you fix the excess commits and conflicts? I guess something went wrong with rebasing.

I tried again, but I guess I failed again. In vscode the merging now looks like:

... and I have not yet checked if my code is up to date, but I have working copies.
Does this look OK to you?

[lsiepel]

You have to merge openHAB main into your GitHub main. And from there in your feature branch. It looks like you updated your feature branch straight from openHAB main

[chilobo]

You have to merge openHAB main into your GitHub main. And from there in your feature branch. It looks like you updated your feature branch straight from openHAB main

I am lost...
Should I try to do something like:
https://community.openhab.org/t/rebase-your-code-or-how-to-fix-your-git-history-before-requesting-a-pull/129358

[lsiepel]

You have to merge openHAB main into your GitHub main. And from there in your feature branch. It looks like you updated your feature branch straight from openHAB main

I am lost... Should I try to do something like: https://community.openhab.org/t/rebase-your-code-or-how-to-fix-your-git-history-before-requesting-a-pull/129358

As from there you pull in the changes from upstream straight into your local branch this can be expected.

1. You could merge openhab main into your github fork main See here: https://github.com/chilobo/openhab-addons/tree/main is 400+ commits behind.
2. Backup the binding folder. Create a new fork / branch etc and in the end a new PR if you can't fix it.

[chilobo]

You have to merge openHAB main into your GitHub main. And from there in your feature branch. It looks like you updated your feature branch straight from openHAB main

I am lost... Should I try to do something like: https://community.openhab.org/t/rebase-your-code-or-how-to-fix-your-git-history-before-requesting-a-pull/129358

As from there you pull in the changes from upstream straight into your local branch this can be expected.

1. You could merge openhab main into your github fork main See here: https://github.com/chilobo/openhab-addons/tree/main is 400+ commits behind.

2. Backup the binding folder. Create a new fork / branch etc and in the end a new PR if you can't fix it.

I went back to a really old version, did a git pull and used my local backup to change the project.
The old pull request was closed - that is OK with me.
Should I delete this fork now?

Then I pushed my local fork to github and opened up a new pull request:
[modbus.lambda] Lambda Heat Pump #17846

But ...
I changed CODEOWNERS, but forgot to change pom.xml in the bundles directory, so the compilation failed.
Now I added
org.openhab.binding.modbus.lambda
in the bundles\pom.xml and pushed it to github.
Will the compilation start automagically or do I have to do something else?

Could you have a look at the new pull request?

[chilobo]

I fixed the DCO failures and the compilations worked out.
So: When you find time, please look at the new pull request.
Should I delete the old fork?

[lsiepel]

I'll look into the new PR, let's continue there.