Clean dashboard code #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quitterie-lcs
force-pushed
the
clean-dashboard-code
branch
2 times, most recently
from
8a6784a to
152ef11
Compare
jmaupetit
reviewed
Jul 20, 2021
Details Dashboard file is restructured according to the common library proposed. Hence, the common library is also improved.
quitterie-lcs
force-pushed
the
clean-dashboard-code
branch
from
152ef11 to
d47c261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Dashboard pages, as they are continuously improved contained more and more panels.
Jsonnet code associated with is becoming huge.
Some fields are used many times through several panels.
Proposal
Following #14 pull request, Details dashboard file is reorganized with the
common.libsonnetfile.