Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump off-dart to 3.18 #5969

Closed
wants to merge 2 commits into from
Closed

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 29, 2024

No description provided.

@g123k g123k linked an issue Nov 29, 2024 that may be closed by this pull request
@g123k g123k marked this pull request as draft November 29, 2024 19:31
@g123k g123k marked this pull request as ready for review November 30, 2024 08:07
@g123k
Copy link
Collaborator Author

g123k commented Nov 30, 2024

@monsieurtanuki Is-it OK to fix nulls like this?
I don't really know how the Prices API works

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 6.53%. Comparing base (4d9c7fc) to head (bf32c5f).
Report is 539 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/smooth_app/lib/database/dao_osm_location.dart 0.00% 2 Missing ⚠️
...kages/smooth_app/lib/pages/prices/price_model.dart 0.00% 2 Missing ⚠️
...s/smooth_app/lib/pages/locations/osm_location.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5969      +/-   ##
==========================================
- Coverage     9.54%   6.53%   -3.02%     
==========================================
  Files          325     440     +115     
  Lines        16411   24836    +8425     
==========================================
+ Hits          1567    1623      +56     
- Misses       14844   23213    +8369     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monsieurtanuki
Copy link
Contributor

@monsieurtanuki Is-it OK to fix nulls like this? I don't really know how the Prices API works

Not it's not. Let me do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Map the contributor field
3 participants