Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Product page - manage user lists in a bottom sheet #5778

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 2, 2024

Hi everyone!

Instead of using dialogs, handling users lists from the product page is now using a bottom sheet.
If there is no list -> the (old) dialog is shown
If there is at least one list -> a list is shown + an inline way to create dialogs

Here is a demo:

  1. There is no user list (= dialog)
  2. A list is "inline" created
  3. A list can't be created if it has the same name as another
  4. A third list is created
ScreenRecording_11-02-2024.04-27-14_1.MP4

@g123k g123k linked an issue Nov 2, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 5.05415% with 263 lines in your changes missing coverage. Please review.

Project coverage is 7.05%. Comparing base (4d9c7fc) to head (c58f41e).
Report is 413 commits behind head on develop.

Files with missing lines Patch % Lines
...oth_app/lib/pages/product/product_list_helper.dart 3.60% 187 Missing ⚠️
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 3.22% 30 Missing ⚠️
...ckages/smooth_app/lib/widgets/smooth_checkbox.dart 0.00% 23 Missing ⚠️
...b/bottom_sheets/smooth_draggable_bottom_sheet.dart 0.00% 12 Missing ⚠️
...pages/product/product_page/new_product_footer.dart 0.00% 8 Missing ⚠️
packages/smooth_app/lib/themes/smooth_theme.dart 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5778      +/-   ##
==========================================
- Coverage     9.54%   7.05%   -2.50%     
==========================================
  Files          325     411      +86     
  Lines        16411   22215    +5804     
==========================================
  Hits          1567    1567              
- Misses       14844   20648    +5804     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for keeping the modal ? temporary ?
image

@g123k
Copy link
Collaborator Author

g123k commented Nov 2, 2024

any reason for keeping the modal ? temporary ? image

This dialog is still used in "My lists" tab + weird to have a centered button: where should the field be placed?

@teolemon teolemon merged commit 0662041 into openfoodfacts:develop Nov 2, 2024
6 checks passed
@g123k g123k deleted the product_page_user_lists branch November 7, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Use a bottom sheet to select a list (product page)
3 participants