Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom layout for the scan page #1908

Merged
merged 2 commits into from
May 22, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 20, 2022

"The same but different"

The Scan Page now uses a custom layout.
The only "visible" change: if action buttons are visible and there is not enough space for the visor, it will be shifted a little bit.

Will fix #1708 and #1794

@g123k g123k requested a review from a team as a code owner May 20, 2022 13:58
@g123k g123k self-assigned this May 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1908 (fae1b0d) into develop (2ea0da3) will decrease coverage by 0.93%.
The diff coverage is 15.79%.

@@            Coverage Diff             @@
##           develop   #1908      +/-   ##
==========================================
- Coverage     8.86%   7.92%   -0.94%     
==========================================
  Files          161     177      +16     
  Lines         6623    8189    +1566     
==========================================
+ Hits           587     649      +62     
- Misses        6036    7540    +1504     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...th_app/lib/cards/data_cards/image_upload_card.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/cards/data_cards/score_card.dart 4.54% <0.00%> (-0.22%) ⬇️
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_element_card.dart 0.00% <0.00%> (ø)
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94524d...fae1b0d. Read the comment docs.

@teolemon teolemon merged commit 8381b82 into openfoodfacts:develop May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Scan area isn't properly centered in the visible viewfinder
3 participants