Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan area isn't properly centered in the visible viewfinder #1708

Closed
M123-dev opened this issue Apr 29, 2022 · 5 comments · Fixed by #1908
Closed

Scan area isn't properly centered in the visible viewfinder #1708

M123-dev opened this issue Apr 29, 2022 · 5 comments · Fixed by #1908
Assignees
Labels
layout 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Milestone

Comments

@M123-dev
Copy link
Member

What

Screenshot_20220429-164740.jpg

@teolemon teolemon added layout 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels Apr 29, 2022
@teolemon teolemon changed the title Scan area isn't in center Scan area isn't properly centered in the visible viewfinder Apr 30, 2022
@teolemon
Copy link
Member

teolemon commented Apr 30, 2022

@monsieurtanuki
Copy link
Contributor

@teolemon I don't plan to approve #1582 as long as it uses copied/pasted code, when an elegant (and suggested) inheritance is possible.
I don't think the displayed viewfinder and the focus point are programmatically connected - though obviously the end-user would expect some consistency. I think we can even scan invisible barcodes, for instance a barcode hidden by the carousel.

@teolemon teolemon added this to the V1 milestone May 4, 2022
@g123k
Copy link
Collaborator

g123k commented May 9, 2022

This ticket is actually just a UI issue.
=> nothing related to the scan performance

I really love your draw @M123-dev, but I'm not sure where you want the visor to be.
Could you elaborate a bit more, please?

@M123-dev
Copy link
Member Author

M123-dev commented May 9, 2022

Sure @g123k the upper line is way shorter then the lower one. The ViewFinder should be centered in between the top and the carousel not directly below the "Clear" and "Compare" buttons

@M123-dev
Copy link
Member Author

M123-dev commented May 9, 2022

Comment by @stephanegigandet in #1794

I used to have the scan area in the good position, but with recent updates, it's now on top of the screen.

Screenshot/Mockup/Before-After

image

Smartphone model

  • Device: Galaxy S8

@g123k g123k self-assigned this May 19, 2022
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layout 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging a pull request may close this issue.

4 participants